feat: add ICameraProjector.TryProjectToPixel (base-frame point → pixel)#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
bool TryProjectToPixel(Point3<double> basePoint, out Point<double> pixel)toICameraProjector/CameraProjector— the inverse of the existingProjectPoint(pixel → 3D).Why
Programs need to draw a known robot-base 3D point (e.g. a teaching point) onto the live camera overlay. The projector already held intrinsics + hand-eye + current pose privately, and
CameraIntrinsics.PointToPixel(pinhole + Brown-Conrady) was public, but there was no public base→pixel entry point. This surfaces it without exposing intrinsics.Returns
falsewhen the point is on or behind the image plane (camera-frameZ ≤ 0), where a pinhole projection would otherwise yield a misleading in-front pixel. Callers clip the returned pixel to their actual viewport bounds.Tests
CameraProjectorTryProjectToPixelTests— 20 strict cases:Z = 0,-0.001,-500) →false+ default pixelfalseFx·100/Z)Full
RocketWelder.SDK.Automation.Tests: 25/25 green.🤖 Generated with Claude Code