Skip to content

[bugfix] avoid duplicate resize for Qwen3-Omni#9729

Open
taking-lying-flat wants to merge 1 commit into
modelscope:mainfrom
taking-lying-flat:fix/qwen3-omni-double-resize
Open

[bugfix] avoid duplicate resize for Qwen3-Omni#9729
taking-lying-flat wants to merge 1 commit into
modelscope:mainfrom
taking-lying-flat:fix/qwen3-omni-double-resize

Conversation

@taking-lying-flat

Copy link
Copy Markdown

PR type

[bugfix] avoid duplicate resize for Qwen3-Omni

PR information

Qwen3-Omni images and videos are already resized by fetch_image /
fetch_video in replace_tag. Disable resizing in the processor to
avoid resizing visual inputs twice during training.

Qwen2.5-Omni behavior remains unchanged because its previous
do_resize value was already False.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the processor call in swift/template/templates/qwen.py by hardcoding the do_resize parameter to False instead of conditionally setting it based on the template version. There are no review comments, and I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant