feat: support supplementary environment variables for hooks in App#5916
Open
Slackow wants to merge 1 commit intomodrinth:mainfrom
Open
feat: support supplementary environment variables for hooks in App#5916Slackow wants to merge 1 commit intomodrinth:mainfrom
Slackow wants to merge 1 commit intomodrinth:mainfrom
Conversation
…nv var substitution in hooks
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the following feature:
#1238
This is a feature present on other popular launchers (e.g. MultiMC, PrismLauncher, ATLauncher), so it would be great to include here as well to support more advanced hooking.
There was a PR open for this a while ago that was closed for being stale:
#1254
The difference with this PR is that instead of only substituting the text in the command, the variables are also provided as part of the environment, and arbitrary environment variables can be expanded. (e.g.
$HOME), this is more in line with other launcher's implementations, and it also applies to all 3 hooks.This does make it larger in scope, so a more thorough review is probably required, especially as a first time contributor. Thank you.