Skip to content

refactor: app event bus - #6985

Open
IMB11 wants to merge 19 commits into
mainfrom
cal/app-frontend-eventbus
Open

refactor: app event bus#6985
IMB11 wants to merge 19 commits into
mainfrom
cal/app-frontend-eventbus

Conversation

@IMB11

@IMB11 IMB11 commented Aug 4, 2026

Copy link
Copy Markdown
Member
  • Refactors scattered emit/listen calls across the app-frontend into a centralised event bus DI provider
  • Event types now have a source of truth coming from the app backend, there were lots of places where they were outdated/didn't even work lol

@IMB11
IMB11 requested a review from aecsocket August 4, 2026 13:06
@modrinth-bot

Copy link
Copy Markdown
Member

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@IMB11
IMB11 changed the base branch from main to boris/redis-postcard August 4, 2026 14:00
@IMB11
IMB11 force-pushed the cal/app-frontend-eventbus branch from d4a2446 to ec86b48 Compare August 4, 2026 14:01
@modrinth-bot

modrinth-bot commented Aug 4, 2026

Copy link
Copy Markdown
Member

@IMB11

IMB11 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Merge after #6956 - depends on the new serde_binhum

@mergify

mergify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@IMB11
IMB11 force-pushed the boris/redis-postcard branch from c558a46 to c86d735 Compare August 4, 2026 16:20
@IMB11
IMB11 force-pushed the cal/app-frontend-eventbus branch from d466de4 to 0c92db2 Compare August 4, 2026 16:20
Base automatically changed from boris/redis-postcard to main August 5, 2026 10:36
@IMB11

IMB11 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

rebase

⚠️ Cannot use the command rebase

Details

⚠ The product Workflow Automation needs to be activated to enable this feature.

@IMB11

IMB11 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

rebase

❌ Unable to rebase: Mergify can't impersonate IMB11

Details

User IMB11 used as bot_account is unknown. Please make sure IMB11 exists and has logged into the Mergify dashboard.

@IMB11

IMB11 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

rebase

❌ Base branch update has failed

Details

PullRequest::RebaseConflictError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants