fix(nextjs-mf): await async factories and return wrapper factory in server onLoad - #4974
Open
shashank-u03 wants to merge 2 commits into
Open
fix(nextjs-mf): await async factories and return wrapper factory in server onLoad#4974shashank-u03 wants to merge 2 commits into
shashank-u03 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: cc62ed0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shashank-u03
force-pushed
the
fix/nextjs-mf-onload-async-fact
branch
from
August 8, 2026 18:23
eb80f2d to
194e558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remote containers in
@module-federation/runtimeexpose async module factories (RemoteEntryExports.getreturns() => Promise<Module>).During the webpack build/SSR path,
runtime-coreloads remotes withloadFactory: falseandfrom: 'build'(seepackages/webpack-bundler-runtime/src/remotes.ts), passing the unexecuted factory tonextjs-mf'sonLoadhook asexposeModuleFactory.On the server,
onLoadsynchronously invoked that factory and Proxy-wrapped the return value for chunk-usage tracking. When the factory is async, the sync invocation returned a rawPromise. Proxy-wrapping thatPromisecaused webpack's async module runtime to fail when calling.then():TypeError: Method Promise.prototype.then called on incompatible receiver [object Promise]
runtime-corecatches this inloadRemoteand routes it toerrorLoadRemotewithlifecycle: 'onLoad'andfrom: 'build'.Fix:
Promiseresults frommoduleOrFactory()before applying the existing Proxy wrapper on the server.exposeModuleFactory, return a wrapper factory soloadRemotecan adopt the proxied result (runtime-coreonly usesonLoad's return when it is a function - seepackages/runtime-core/src/remote/index.ts).runtime-corealready handles async factories inmodule.wraperFactory; this alignsnextjs-mfonLoadwith that behavior.Tests added in
runtimePlugin.test.ts:Promise.prototype.thenis not broken after the fixexposeModuleFactorystill workswindowpresent) still returnsargsunchangedNote on
async onLoad:loadRemotealwaysawaitsonLoad.emit()andAsyncHook.emitwraps listener returns withPromise.resolve(). The client branch still returnsargsunchanged; only the server branch gained internalawaitlogic.Related Issue
#2218
Types of changes
Checklist