Skip to content

chore(deps): bump chai from 4.5.0 to 6.2.2#653

Open
dependabot[bot] wants to merge 4 commits intomainfrom
dependabot/npm_and_yarn/chai-6.2.2
Open

chore(deps): bump chai from 4.5.0 to 6.2.2#653
dependabot[bot] wants to merge 4 commits intomainfrom
dependabot/npm_and_yarn/chai-6.2.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 16, 2026 •
edited
Loading

Bumps chai from 4.5.0 to 6.2.2.

Release notes

Sourced from chai's releases.

v6.2.2

What's Changed

New Contributors

Full Changelog: chaijs/chai@v6.2.1...v6.2.2

v6.2.1

What's Changed

New Contributors

Full Changelog: chaijs/chai@v6.2.0...v6.2.1

... (truncated)

Commits
  • 814172d chore(deps): update dependency esbuild to v0.27.2 (#1759)
  • b38c22b chore: add legal-comments=none option (#1756)
  • 180d4cc chore(deps): update dependencies to v9.39.2 (#1757)
  • 678cd00 chore(deps): update dependencies (#1755)
  • c8fb100 chore(deps): update dependency prettier to v3.7.3 (#1754)
  • d63c74e chore(deps): update dependency eslint-plugin-jsdoc to v61.4.1 (#1751)
  • 243bf86 fix: avoid BigInt literal in closeTo for runtime compat (#1748)
  • d8b0395 chore(deps): update actions/checkout action to v6 (#1749)
  • 7e1e247 build(deps): bump glob from 10.4.5 to 10.5.0 (#1747)
  • b25e5d8 chore(deps): update dependency eslint-plugin-jsdoc to v61.2.1 (#1746)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for chai since your current version.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Apr 16, 2026
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/chai-6.2.2 branch 9 times, most recently from d425128 to cbcc161 Compare April 16, 2026 17:52
@dependabot
chore(deps): bump chai from 4.5.0 to 6.2.2
5d4ba7f 
Bumps [chai](https://github.com/chaijs/chai) from 4.5.0 to 6.2.2.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@v4.5.0...v6.2.2)

---
updated-dependencies:
- dependency-name: chai
  dependency-version: 6.2.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/chai-6.2.2 branch from cbcc161 to 5d4ba7f Compare April 16, 2026 17:54
@nirinchev
Copy link
Copy Markdown
Collaborator

nirinchev commented Apr 16, 2026

@copilot resolve the test failure

@nirinchev
fix: update sinon-chai to v4 and dedupe chai for Chai 6 compatibility
dd31534 
- Upgrade sinon-chai from ^3.7.0 to ^4.0.0 in mocha-config-devtools
  (sinon-chai v4 supports Chai 5/6)
- Update sinon-chai-register.js to use sinonChai.default || sinonChai
  (sinon-chai v4 is ESM; require() returns {default: fn})
- Run npm dedupe to hoist chai v6.2.2 to root node_modules so all
  packages share the same chai instance

Agent-Logs-Url: https://github.com/mongodb-js/devtools-shared/sessions/30ac2ca4-74cb-4d66-8df5-a7644ebfa05e

Co-authored-by: nirinchev <2315687+nirinchev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

@copilot resolve the test failure

Fixed in dd31534. The test was failing with Error: Invalid Chai property: calledWith due to two issues:

  1. sinon-chai incompatibility: sinon-chai 3.7.0 only supports Chai 4. Upgraded to sinon-chai v4.0.1 which supports Chai 5/6.
  2. Multiple chai instances: After the chai 6 bump, each workspace had its own isolated chai instance in local node_modules, so chai.use(sinonChai) in sinon-chai-register.js didn't affect the chai instance used by test files. Fixed by running npm dedupe to hoist chai 6.2.2 to root node_modules so all packages share a single instance.
  3. ESM default export: sinon-chai v4 is an ES module, so when require()d it returns { default: fn }. Updated sinon-chai-register.js to use sinonChai.default || sinonChai.

Copilot AI requested a review from nirinchev April 16, 2026 18:34
@nirinchev
Copy link
Copy Markdown
Collaborator

nirinchev commented May 3, 2026

@copilot resolve the merge conflicts and fix the remaining build failures.

@nirinchev
chore: merge main into branch, resolve conflicts and fix TypeScript e…
df02c6d 
…rror

- Resolve merge conflicts across package.json files:
  - Keep chai ^6.2.2 from our branch
  - Take @types/sinon-chai ^4.0.0, acorn, mongodb, cheerio from main
- Use sinon-chai-register.js pattern from main (default ?? module)
- Update package-lock.json via npm install + npm dedupe
- Fix TypeScript error in packages/download-url/src/version-list.ts:
  response.json() now returns unknown in @types/node 22.19.x;
  add explicit cast to FullJSON

Co-authored-by: nirinchev <2315687+nirinchev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 3, 2026

@copilot resolve the merge conflicts and fix the remaining build failures.

Done in df02c6d. Here's what was fixed:

  • Merge conflicts: Merged origin/main (70+ commits ahead) into the branch. Resolved conflicts in package-lock.json and 15 package.json files by keeping chai: ^6.2.2 from this branch while taking @types/sinon-chai: ^4.0.0 and other package updates from main.
  • Build failure (packages/download-url): npm dedupe (used to hoist chai to a single shared instance) bumped @types/node from 22.15.31 → 22.19.17, where Response.json() now returns unknown instead of any. Fixed by adding an explicit cast in version-list.ts: fullJSON = (await response.json()) as FullJSON;
  • sinon-chai register: Adopted the cleaner pattern from main's 045cf8b commit (sinonChaiModule.default ?? sinonChaiModule)

@nirinchev
Copy link
Copy Markdown
Collaborator

nirinchev commented May 3, 2026

@copilot looks like there are more build failures

@nirinchev
fix: add null check for response.body in mongodb-downloader to fix TS…
5fa5049 
…2769

@types/node 22.19.x types Response.body as ReadableStream | null;
the pipeline() overloads don't accept null, so add a null guard before
each pipeline call so TypeScript narrows the type to ReadableStream.

Agent-Logs-Url: https://github.com/mongodb-js/devtools-shared/sessions/3abd748f-532c-4c10-8829-a4eb1ed23cb2

Co-authored-by: nirinchev <2315687+nirinchev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 3, 2026

@copilot looks like there are more build failures

Fixed in 5fa5049. The remaining failures were TypeScript errors in packages/mongodb-downloader/src/index.ts at lines 146 and 155:

error TS2769: No overload matches this call.
  Argument of type 'ReadableStream | null' is not assignable to parameter of type 'PipelineSource<any>'.
    Type 'null' is not assignable to type 'PipelineSource<any>'.

@types/node 22.19.x types Response.body as ReadableStream | null. Added null guards before each pipeline() call so TypeScript narrows the type correctly:

if (!response.body) throw new Error(`No response body for ${url}`);
await promisify(pipeline)(response.body, ...);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nirinchev