MONGOCRYPT-899 fix upload-all copy#1156
Open
kevinAlbs wants to merge 4 commits intomongodb:masterfrom
Open
Conversation
No longer needed after MONGOCRYPT-840
kevinAlbs
changed the title
upload-all copyupload-all copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upload-alltask on the 1.18.0 release failed:Due to this copy:
${tag_upload_location!|*revision}and${tag_upload_location}evaluate the same. But since the copy is guarded by a check for a non-empty${tag_upload_location}, the copy is unnecessary.I do not plan to immediately release 1.18.1 with this fix. libmongocrypt-all.tar.gz is planned for removal in MONGOCRYPT-894. No drivers appear to get binaries directly from this tarball. But I erred towards making this small fix in case there is a need for a 1.18.1 release.