RUBY-3797 Migrate away from set-temp-creds.sh#3065
Closed
comandeo-mongo wants to merge 4 commits into
Closed
Conversation
The legacy csfle/set-temp-creds.sh script is deprecated in drivers-evergreen-tools (DRIVERS-3433). The main run-tests.sh path already moved to setup-secrets.sh under RUBY-3886, and setup_secrets.py now produces the same CSFLE_AWS_TEMP_* credentials. The only remaining consumer was run-tests-serverless.sh, which is dead code: serverless testing was removed in RUBY-3652 and no Evergreen task references the script. Delete it, and fix the now-stale spec_config.rb comments that still pointed at set-temp-creds.sh.
MongoDB 4.2 is on the EOL track (RUBY-3811 deprecated it, RUBY-3819 covers the min-version bump to 4.4). Its CI variants are also currently broken at server bootstrap: drivers-evergreen-tools starts MongoDB >= 4.2 with mongodb-runner, which pins mongodb-runner but not its transitive bson dependency, so the recent bson 7.3.0 release crashes startup. Drop the 4.2 build variants: remove the 4.2 axis value and remove 4.2 from the mongo-4.x and "stress older" matrices. Regenerated config.yml via `rake eg:build`; `rake eg:validate` passes. 4.4 coverage is kept.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Ruby driver’s Evergreen/CI configuration to remove reliance on the deprecated set-temp-creds.sh helper and to drop MongoDB 4.2 build coverage (EOL), aligning the repo’s CI setup with current upstream tooling and supported server versions.
Changes:
- Updated FLE/CSFLE test configuration comments to reference
setup-secrets.shinstead ofset-temp-creds.sh. - Removed the orphaned
.evergreen/run-tests-serverless.shscript (previously the last consumer ofset-temp-creds.sh). - Removed MongoDB 4.2 from Evergreen axes/matrices and regenerated
.evergreen/config.ymlaccordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
spec/support/spec_config.rb |
Updates documentation comments to reflect the current secrets provisioning script (setup-secrets.sh). |
.evergreen/run-tests-serverless.sh |
Deletes dead serverless test runner script (and last set-temp-creds.sh usage). |
.evergreen/config/standard.yml.erb |
Removes MongoDB 4.2 from buildvariant matrices (mongo-4.x, stress older). |
.evergreen/config/axes.yml.erb |
Removes the 4.2 value from the mongodb-version axis. |
.evergreen/config.yml |
Regenerated Evergreen config reflecting removal of the 4.2 axis/matrix entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related Evergreen/CI cleanups under RUBY-3797:
set-temp-creds.sh(the originalscope of this ticket), in preparation for its removal upstream
(DRIVERS-3433).
the EOL track (RUBY-3811 deprecated it; RUBY-3819 covers the
min-version bump to 4.4), and its variants are currently broken at
server bootstrap (see note below).
set-temp-creds migration
The legacy
csfle/set-temp-creds.shis deprecated upstream and emits awarning pointing at
setup-secrets.sh. Most of the migration alreadyhappened:
run-tests.shmoved tosetup-secrets.shunder RUBY-3886(#3048), and
setup_secrets.pynow produces the sameCSFLE_AWS_TEMP_*credentials plus Azure/GCP access tokens.
The only remaining consumer was
run-tests-serverless.sh, which is deadcode: serverless testing was removed in RUBY-3652 (#2942) and no Evergreen
task references it.
.evergreen/run-tests-serverless.sh(orphaned; lastset-temp-creds.shconsumer).spec/support/spec_config.rbthat stillreferenced
set-temp-creds.sh; theCSFLE_AWS_TEMP_*env vars theydocument are now produced by
setup-secrets.sh.After this, there are no remaining references to
set-temp-creds.sh.Remove MongoDB 4.2 variants
4.2value from themongodb-versionaxis.4.2from themongo-4.xandstress oldermatrices (4.4 kept)..evergreen/config.ymlviarake eg:build;rake eg:validatepasses.
Note: the 4.2 (and 4.4) variants currently fail at
bootstrap-mongo-orchestrationbecause drivers-evergreen-tools starts MongoDB >= 4.2 with
mongodb-runner,which pins
mongodb-runnerbut not its transitivebsondependency, so therecent
bson@7.3.0release crashes server startup. That root cause must befixed in drivers-evergreen-tools; removing 4.2 only reduces exposure for the
EOL version.
Test plan
CI/shell + Evergreen-config change. No runtime Ruby code is touched.
rake eg:buildregeneratesconfig.yml;rake eg:validatepassesbundle exec rubocop spec/support/spec_config.rb— no offensesgit grep set-temp-creds— no references remaingrep 4.2 .evergreen/config.yml— no 4.2 variants remainJira
https://jira.mongodb.org/browse/RUBY-3797