fix(theme): prevent preview theme CSS from leaking after quick hover exit (@PlutoDog95)#7877
Draft
PlutoDog95 wants to merge 1 commit intomonkeytypegame:masterfrom
Draft
fix(theme): prevent preview theme CSS from leaking after quick hover exit (@PlutoDog95)#7877PlutoDog95 wants to merge 1 commit intomonkeytypegame:masterfrom
PlutoDog95 wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
PlutoDog95
changed the title
Member
|
#7876 already fixes this issue. thanks |
Author
|
Thanks for checking! I appreciate it. I’ll take a look at #7876. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes theme preview CSS leaking when hovering over a theme and quickly closing the theme menu without selecting it.
Root Cause
Theme preview is triggered from the theme command hover handler using
ThemeController.preview(theme.name).This uses a debounced preview function before applying the preview theme.
When the user exits the menu quickly,
clearPreview()resets the preview state, but the pending debounced preview can still execute afterward and apply preview styles after cleanup.This causes parts of the preview theme CSS to remain visible, matching issue #7875.
Fix
Cancel the pending debounced preview inside
clearPreview()before restoring the original theme:debouncedPreview.cancel();This ensures delayed preview application cannot happen after cleanup.
Closes #7875