Repository navigation
fix(credits): static pg/libsql-pg imports for the module pool - #141
Merged
Merged
Conversation
require() of the ESM server external @profullstack/libsql-pg from the Next
bundle returned no connectionSettings, so every credits/invites API call 500'd
in production ("i is not a function"). Verified against a production build on
a scratch Postgres database: redeem, already_redeemed, concurrent invite accept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ThreatCrush Security Scan22 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 14 | LOW: 6
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #140. In production every
/api/creditsand/api/invitescall 500'd withTypeError: i is not a function:require('@profullstack/libsql-pg')(an ESM server external) from the Next bundle came back withoutconnectionSettings. Bothpgandlibsql-pgare now static imports.Verified with
bun run build && bun run startagainst a scratch Postgres database: redeem ok (7 days, plan paid), second redeemalready_redeemed, two concurrent invite accepts (one pending, the otheralready_invitedand still unused).bun test tests/272 pass,tsc --noEmitclean.🤖 Generated with Claude Code