Split VaultService into facade over domain services with centralized VaultStore - #61
Merged
Conversation
Use `BicubicResizer.resizeJpegAsync` to keep JPEG resizing off the UI thread Update `EncryptionService` doc to reflect GCM/CTR support and legacy CBC mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
VaultServiceinto a facade over multiple domain-specific services (Album, File, Folder, Search, Settings, Stats, Tag, VaultStore) for improved modularity. Adds encrypted thumbnail service with caching, migrate office document conversion to isolate, and adds comprehensive tests.Changes
Architecture
VaultServiceinto a facade over split domain servicesVaultStoreas centralized state and persistence layerVaultSettingsmodel for configuring vault behaviorDomain Services
AlbumServicefor CRUD and file-album managementSettingsServicewith get/update methodsStatsServicefor read-only file analyticsTagServicefor tag CRUD and favorite togglingEncrypted Thumbnails
Import Flow
setStatewith progress sheet bottom modal for import flowDocument Conversion
PDF Viewer
Testing
VaultServiceOther
vaultServiceProviderusage withVaultService.instancecleanupTempto useVaultServicesingleton