Add live WebDAV integration tests and fix nested-PUT 409 bug - #68
Merged
Conversation
Replace LinearGradient with a flat accent color in the floating capsule bottom bar decoration.
Spec-strict WebDAV servers (rclone, mod_dav) return 409 when a nested PUT's parent collection is missing. Nextcloud auto-creates and masks this, but other servers do not. The new `_ensureParent` helper creates any missing parent directories idempotently before writing.
Adds `test/live_webdav_test.dart` covering S0.5 (WebDAVStore raw transport — ping, manifest/blob roundtrip, delete, list) and S3.4 (two-device two-way `runSync` — push/pull, edit propagation, tombstone propagation, tampered-blob rejection). Tests are env-gated behind `LOCKER_LIVE_WEBDAV_URL`.
`test/live_webdav_test.dart` covers S0.5 + S3.4 against a real WebDAV server (env-gated via `LOCKER_LIVE_WEBDAV_URL`). S0.5 surfaced and fixed a nested-PUT 409 bug — `WebDAVStore` now `MKCOL`s parent dirs idempotently. Orphan blob GC is deferred; tracked in S3 ceilings.
Break up long argument lists and expect calls across multiple lines for readability. Comment out three unused imports (encryption_algorithm, remote_store, pointycastle).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a live WebDAV integration test suite (env-gated) covering raw transport and two-device two-way sync, fixes a nested-PUT 409 bug by idempotently creating parent directories, and simplifies the floating capsule accent to a solid color.
Changes
WebDAV Fixes
_ensureParenthelperTesting
LOCKER_LIVE_WEBDAV_URLUI
LinearGradient)