Add icon + license to the gallery .vsix; set author to Christian Mourier#4
Conversation
extension.vsixmanifest.v2 now declares <Icon>icon.png</Icon> and <License>LICENSE.txt</License>; release.yml bundles the repo logo and Apache LICENSE into the .vsix and adds png/txt content types so the OPC package stays valid. Fixes the gallery's missing-icon / no-license warnings. Install-verified on SSMS 22 (exit 0, both assets present).
Was 'SQL Pilot Contributors' in the VSIX manifests (gallery author) and Directory.Build.props (assembly Authors/Copyright).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR updates publisher/author metadata across Directory.Build.props and VSIX manifests to "Christian Mourier", and modifies the release workflow to stage an icon.png and LICENSE.txt into the VSIX package with corresponding content-type declarations. ChangesPublisher metadata update
Gallery VSIX icon and license bundling
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: documentation, release, chore Suggested reviewers: mourier 🐰 A new name upon the scroll, 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Closes #3.
Icon + license (#3)
The v1.1.0 gallery listing flagged a missing icon and no license. Now:
extension.vsixmanifest.v2declares<Icon>icon.png</Icon>and<License>LICENSE.txt</License>.release.ymlbundles the repo logo (.github/logo.png→icon.png) and the ApacheLICENSE(→LICENSE.txt) into the.vsixstaging, and addspng/txtcontent types to[Content_Types].xmlso the OPC package stays valid..vsix/gallery path — the loose-file install and payload ZIP are unchanged.Install-verified on real SSMS 22: fresh install exit 0;
icon.png+LICENSE.txtland in the install dir; manifest carries both elements. (Thepng/txtcontent-type additions were the real risk — a missing content type would make the OPC package invalid, the same class of bug the earlier install gate caught. Verified clean.)Author → Christian Mourier
Per request, changed the author/publisher from "SQL Pilot Contributors" to Christian Mourier:
.v1<Author>,.v2+ sourcePublisher) — the gallery author.Directory.Build.props<Authors>and<Copyright>— assembly metadata.<Company>/<Product>stay "SQL Pilot" (product name, not author).Both land in the gallery on the next release tag.
Summary by CodeRabbit