Skip to content

Add icon + license to the gallery .vsix; set author to Christian Mourier#4

Merged
mourier merged 2 commits into
mainfrom
worktree-vsix-icon-license
Jul 1, 2026
Merged

Add icon + license to the gallery .vsix; set author to Christian Mourier#4
mourier merged 2 commits into
mainfrom
worktree-vsix-icon-license

Conversation

@mourier

@mourier mourier commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Closes #3.

Icon + license (#3)

The v1.1.0 gallery listing flagged a missing icon and no license. Now:

  • extension.vsixmanifest.v2 declares <Icon>icon.png</Icon> and <License>LICENSE.txt</License>.
  • release.yml bundles the repo logo (.github/logo.pngicon.png) and the Apache LICENSE (→ LICENSE.txt) into the .vsix staging, and adds png/txt content types to [Content_Types].xml so the OPC package stays valid.
  • Confined to the .vsix/gallery path — the loose-file install and payload ZIP are unchanged.

Install-verified on real SSMS 22: fresh install exit 0; icon.png + LICENSE.txt land in the install dir; manifest carries both elements. (The png/txt content-type additions were the real risk — a missing content type would make the OPC package invalid, the same class of bug the earlier install gate caught. Verified clean.)

Author → Christian Mourier

Per request, changed the author/publisher from "SQL Pilot Contributors" to Christian Mourier:

  • VSIX manifests (.v1 <Author>, .v2 + source Publisher) — the gallery author.
  • Directory.Build.props <Authors> and <Copyright> — assembly metadata.

<Company>/<Product> stay "SQL Pilot" (product name, not author).

Both land in the gallery on the next release tag.

Summary by CodeRabbit

  • New Features
    • Updated the packaged extension to include the required gallery assets, such as an icon and license file.
  • Bug Fixes
    • Improved VSIX packaging metadata so added image and text assets are correctly recognized.
  • Chores
    • Updated published author/publisher and copyright information in extension metadata.

mourier added 2 commits July 1, 2026 22:43
extension.vsixmanifest.v2 now declares <Icon>icon.png</Icon> and
<License>LICENSE.txt</License>; release.yml bundles the repo logo and
Apache LICENSE into the .vsix and adds png/txt content types so the OPC
package stays valid. Fixes the gallery's missing-icon / no-license
warnings. Install-verified on SSMS 22 (exit 0, both assets present).
Was 'SQL Pilot Contributors' in the VSIX manifests (gallery author) and
Directory.Build.props (assembly Authors/Copyright).
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98f56101-bd92-4f72-b1b0-ed4608e28deb

📥 Commits

Reviewing files that changed from the base of the PR and between 491d827 and 80fb62b.

📒 Files selected for processing (5)
  • .github/workflows/release.yml
  • Directory.Build.props
  • src/SqlPilot.Package/extension.vsixmanifest.v1
  • src/SqlPilot.Package/extension.vsixmanifest.v2
  • src/SqlPilot.Package/source.extension.vsixmanifest

📝 Walkthrough

Walkthrough

This PR updates publisher/author metadata across Directory.Build.props and VSIX manifests to "Christian Mourier", and modifies the release workflow to stage an icon.png and LICENSE.txt into the VSIX package with corresponding content-type declarations.

Changes

Publisher metadata update

Layer / File(s) Summary
Publisher/author metadata
Directory.Build.props, src/SqlPilot.Package/extension.vsixmanifest.v1, src/SqlPilot.Package/extension.vsixmanifest.v2, src/SqlPilot.Package/source.extension.vsixmanifest
Copyright, Authors, Publisher, and Author values change from "SQL Pilot Contributors" to "Christian Mourier".

Gallery VSIX icon and license bundling

Layer / File(s) Summary
Stage and declare gallery assets
.github/workflows/release.yml
Copies repo logo to icon.png and LICENSE to LICENSE.txt into the VSIX staging directory, and adds png/txt entries to [Content_Types].xml.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • mourier/sql-pilot#2: Both PRs modify the VSIX packaging staging step and regenerate [Content_Types].xml in .github/workflows/release.yml.

Suggested labels: documentation, release, chore

Suggested reviewers: mourier

🐰 A new name upon the scroll,
An icon and license now console
The gallery's empty, wistful stare—
Christian's mark is written there,
Packed and zipped, the VSIX whole.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The author/publisher updates in Directory.Build.props and the manifests go beyond #3’s icon/license gallery fix. Move the author/publisher metadata changes to a separate PR or remove them if they are not required for the gallery fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main VSIX gallery icon, license, and author metadata changes.
Linked Issues check ✅ Passed The PR adds the required icon and license metadata and bundles the referenced files inside the VSIX package as requested by #3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-vsix-icon-license

Comment @coderabbitai help to get the list of available commands.

@mourier mourier merged commit 348c0be into main Jul 1, 2026
2 checks passed
@mourier mourier deleted the worktree-vsix-icon-license branch July 1, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add icon and license to the gallery .vsix manifest

1 participant