Repository navigation
Conversation
税金込み価格を計算する機能を実装
Signed-off-by: maou1d <maoyoshida06@gmail.com>
Add dice provider to the urlbar
Urlbar custom shortcut
Add microsleep urlbar provider
Signed-off-by: maou1d <maoyoshida06@gmail.com>
Urlbar countdown
No Taskcluster jobs started for this pull requestThe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
UrlbarProvidersManager内で、UrlbarProviderDiceの設定キーがsupportedSAPsではなくupportedSAPsになっていたtypoを修正しました。（おそらく私がマージ時のコンフリクト解消の際に誤ってsまで消してしまった）問題
このtypoにより、SAPでプロバイダを絞り込む初期化処理で失敗し、結果としてURLバーの挙動が壊れる可能性がありました。
対応内容
以下の1点を修正しました。
upportedSAPs→supportedSAPs動作確認
fix/urlbar-supportedsaps-typoというブランチにスイッチしてもらって、ビルドしurlbarがアクセス可能で、diceやmicrosleep、既存の2+3等のプロバイダが実行できていることが確認されれば十分です。Lando: link
🚫 This pull request has 4 blockers.