fix: don't overflow GCS custom-time - #2541
Merged
Merged
Conversation
it apparently tops off at go's max UnixNano (around year 2262), we'll use 2200 because it's maybe more easily identifiable Closes STOR-682
pjenvey
force-pushed
the
fix/custom-time-STOR-682
branch
from
August 21, 2026 17:17
bdc48fa to
2741ec1
Compare
chenba
approved these changes
Aug 21, 2026
chenba
left a comment
chenba
left a comment
Collaborator
There was a problem hiding this comment.
future devsllms gonna be mad at us for not setting a date further out!
Collaborator
haha. So long as we pick the estimated heat death of the universe, or when the sun gobbles up the earth, the LLMs should be pleased. |
taddes
approved these changes
Aug 21, 2026
taddes
left a comment
taddes
left a comment
Collaborator
There was a problem hiding this comment.
🚀 the future is coming on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
it apparently tops off at go's max UnixNano (around year 2262), we'll use 2200 because it's maybe more easily identifiable
Issue(s)
Closes STOR-682