[RS] Run maintenance after each sync

[issammani]

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

[bendk]

Changes look great, thanks for fixing this.

[jonalmeida]

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

[bendk]

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

I think the mobile clients are already calling RemoteSettingsService::sync() which means they'll get this automatically. So we should double check that for sure, but maybe we don't need to land any other patches.

[issammani]

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

I think the mobile clients are already calling RemoteSettingsService::sync() which means they'll get this automatically. So we should double check that for sure, but maybe we don't need to land any other patches.

In the worst case scenario, we will run the sync one day after the fix lands. This should be enough.

[jonalmeida]

r+ we will need client-side patches for iOS and Android to execute this I think, but can get there easily since we've done this before and we don't have breaking API changes here.

I think the mobile clients are already calling RemoteSettingsService::sync() which means they'll get this automatically. So we should double check that for sure, but maybe we don't need to land any other patches.

In the worst case scenario, we will run the sync one day after the fix lands. This should be enough.

Thanks, good catch. We are running sync every 24 hours, but that is going to be increased to every 2 hours.

[issammani]

@mergify backport release-v151

[mergify]

backport release-v151

✅ Backports have been created

Details

• #7352 [RS] Run maintenance after each sync (backport #7342) has been created for branch release-v151 but encountered conflicts

Cherry-pick of 903526a has failed:

On branch mergify/bp/release-v151/pr-7342
Your branch is up to date with 'origin/release-v151'.

You are currently cherry-picking commit 903526a2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   components/remote_settings/src/client.rs
	modified:   components/remote_settings/src/storage.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   components/remote_settings/src/service.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally