Bug 2012185 - add validation step to nimbus-fml generate#7350
Merged
freshstrangemusic merged 1 commit intomozilla:mainfrom May 6, 2026
Merged
Conversation
freshstrangemusic
previously requested changes
May 5, 2026
Member
freshstrangemusic
left a comment
There was a problem hiding this comment.
I would like to see a test where we invoke the generate command and it fails for something in validate (ie the test will fail without this patch)
c41ba64 to
2f22e8d
Compare
The pull request has been modified, dismissing previous reviews.
2f22e8d to
8cbeb97
Compare
freshstrangemusic
previously approved these changes
May 6, 2026
8cbeb97 to
4be5a89
Compare
4be5a89 to
45c4f60
Compare
The pull request has been modified, dismissing previous reviews.
freshstrangemusic
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
nimbus-fml generateto include the same validation logic asnimbus-fml validateallowing build scripts to rely solely on generatePull Request checklist
[ci full]to the PR title.