Skip to content

Bug 2012185 - add validation step to nimbus-fml generate#7350

Merged
freshstrangemusic merged 1 commit intomozilla:mainfrom
moibra05:nimbus-fml-generate-add-validation
May 6, 2026
Merged

Bug 2012185 - add validation step to nimbus-fml generate#7350
freshstrangemusic merged 1 commit intomozilla:mainfrom
moibra05:nimbus-fml-generate-add-validation

Conversation

@moibra05
Copy link
Copy Markdown
Contributor

@moibra05 moibra05 commented May 5, 2026

Updates nimbus-fml generate to include the same validation logic as nimbus-fml validate allowing build scripts to rely solely on generate

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Copy link
Copy Markdown
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a test where we invoke the generate command and it fails for something in validate (ie the test will fail without this patch)

@moibra05 moibra05 force-pushed the nimbus-fml-generate-add-validation branch from c41ba64 to 2f22e8d Compare May 6, 2026 15:16
@mergify mergify Bot dismissed freshstrangemusic’s stale review May 6, 2026 15:17

The pull request has been modified, dismissing previous reviews.

@moibra05 moibra05 force-pushed the nimbus-fml-generate-add-validation branch from 2f22e8d to 8cbeb97 Compare May 6, 2026 15:18
@moibra05 moibra05 requested a review from freshstrangemusic May 6, 2026 15:18
Comment thread components/support/nimbus-fml/src/command_line/workflows.rs Outdated
@moibra05 moibra05 force-pushed the nimbus-fml-generate-add-validation branch from 8cbeb97 to 4be5a89 Compare May 6, 2026 17:10
@moibra05 moibra05 force-pushed the nimbus-fml-generate-add-validation branch from 4be5a89 to 45c4f60 Compare May 6, 2026 17:10
@mergify mergify Bot dismissed freshstrangemusic’s stale review May 6, 2026 17:11

The pull request has been modified, dismissing previous reviews.

@freshstrangemusic freshstrangemusic added this pull request to the merge queue May 6, 2026
Merged via the queue into mozilla:main with commit 4809c2f May 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants