Skip to content

Bug 2034610 - Reduce allocations in unenroll_for_gecko_pref#7351

Queued
freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic/push-xtlwsxlvsqnw
Queued

Bug 2034610 - Reduce allocations in unenroll_for_gecko_pref#7351
freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic/push-xtlwsxlvsqnw

Conversation

@freshstrangemusic
Copy link
Copy Markdown
Member

We end up allocating a Vec<Vec> and calling concat() instead of allocating a Vec and passing a &mut Vec in these functions.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

We end up allocating a Vec<Vec<T>> and calling concat() instead of
allocating a Vec<T> and passing a &mut Vec<T> in these functions.
Copy link
Copy Markdown
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@freshstrangemusic freshstrangemusic added this pull request to the merge queue May 7, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants