Added Post Quantum Server Testing Program#7
Merged
Conversation
alexcottner
reviewed
Jan 14, 2026
alexcottner
reviewed
Jan 14, 2026
alexcottner
reviewed
Jan 14, 2026
alexcottner
reviewed
Jan 14, 2026
alexcottner
reviewed
Jan 14, 2026
e0a5d9d to
5d12506
Compare
say-yawn
reviewed
Jan 14, 2026
say-yawn
left a comment
There was a problem hiding this comment.
Minor suggestion and some questions:
- why is there a
GenerateKey()for both Falcon and RSA tests but not for MLDSA and ECDSA? - Why generate a new key for every test case for Falcon and RSA?
- Why generate the RSA key locally rather than creating/storing it in the KMS?
- Is the expectation that a key named
mldsaandecdsawith ML-DSA-65 and RSA-4096 respectively already created and stored in the KMS? If so, I recommend sharing the requirement/instructions about this on the README.
Comment on lines
+14
to
+16
| sigName = "Falcon-512" | ||
| PublicKeySize = 897 | ||
| PrivateKeySize = 1281 |
There was a problem hiding this comment.
According to the internet (not official Go doc), you use uppercase if you are exporting the constant variable. Will you make changes to the variable names so they are consistent with the usage?
Collaborator
Author
There was a problem hiding this comment.
Thanks. I'll change the variable names to uppercase.
alexcottner
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes