Repository navigation
Conversation
Because: - We want CI checks and automatic releases on merge This commit: - Adds CI workflows, semantic-release, and image publishing to GHCR
StaberindeZA
approved these changes
Oct 19, 2026
StaberindeZA
left a comment
StaberindeZA
left a comment
Collaborator
There was a problem hiding this comment.
r+ with some optional changes.
I ran a Claude review and below is some of feedback it came back with on what would be good to fix.
Most important:
- .github/workflows/ci.yml:107: The release version comes from git tag --points-at HEAD, not from what semantic-release actually did. If someone re-runs an old workflow on main, it can push an old version again and move :latest back to it.
- .github/workflows/ci.yml:90: On push, the release tag is created before anything checks that the Docker image builds. If the image build then fails, you're left with a version tag that has no image.
- .dockerignore:8: Only env files at the repo root are excluded. Secret files inside apps/ or libs/ would be copied into the build layers, which are cached in GitHub Actions.
IMO 2 and 3 would be good to fix, but also fine to leave things as is.
julianpoy
marked this pull request as ready for review
October 21, 2026 04:16
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
dev.envanddev.local.envso Nx doesn't load them into tasksIssue that this pull request solves
Closes: N/A
Checklist