feat(HNT-2115): add redis-state client package - #18
Draft
mmiermans wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
HNT-2115
Add a generic
redis-statepackage: a module-levelioredisclient that exposes fetch and enqueue timestamps, string values, ownership-checked locks, and an atomic token-bucket primitive. This is the state the crawler needs for deduplication and for a shared rate limit, and it lives in its own package because none of it carries any crawl domain.See docs/ARCHITECTURE.md in #14 for where the state store sits in the system.
Implementation decisions
ioredisas the Redis clientioredis, mirroring the shape of the Zyte and Pub/Sub clientseval, lazy connect, and automatic reconnection, all of whichioredisprovides directly. It is also the Redis client already used elsewhere in the Mozilla org, infxaandblurts-server.TIMEfor elapsed time and runs atomicallyacquireRateLimitTokenas a plain Redis operation, and the crawler wiring lands later in the distributed Zyte rate limiter slicecommandTimeoutand cap retries per request