Marky fixes and refreshment - #7740
Draft
denyshon wants to merge 1 commit into
Draft
Conversation
denyshon
marked this pull request as draft
July 27, 2026 05:48
Contributor
Author
|
I'll need to rewrite this since #7718 has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves mozilla/sumo#3221, resolves mozilla/sumo#3230, resolves mozilla/sumo#3231, resolves mozilla/sumo#3232, resolves mozilla/sumo#3234, resolves mozilla/sumo#3235, resolves mozilla/sumo#3233, resolves mozilla/sumo#3236.
SimpleButtoninto two classes:MarkupButton(which keeps the old behavior) andInsertButton(which replaces the selection instead of framing it).LinkButton,MediaButton,CannedResponsesButtonandQuoteButtonnow inherit fromInsertButton, which also contains some shared code.LinkButtonkbox to and make the link fields required (link type must be selected, and a link for this type must be specified). Disable the Insert button until the form is valid.</div>in theLinkButtonkbox html template (its absence led to an extra margin at the bottom).