Skip to content

Close abandoned index scans - #7797

Open
akatsoulas wants to merge 1 commit into
mozilla:mainfrom
akatsoulas:retrieval-scroll-hygiene
Open

Close abandoned index scans#7797
akatsoulas wants to merge 1 commit into
mozilla:mainfrom
akatsoulas:retrieval-scroll-hygiene

Conversation

@akatsoulas

Copy link
Copy Markdown
Collaborator

No description provided.

@akatsoulas
akatsoulas requested a review from escattone August 5, 2026 17:58

@escattone escattone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

Should the scan in the test utility function read_indexed_document() in kitsune/retrieval/tests/__init__.py also get wrapped with a closing context manager?

Comment on lines +991 to +992
Asserting on the generator rather than on a scroll count keeps this independent of when
CPython happens to collect it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of the comment valid? It seems that the _assert_all_closed method does assert on scroll count?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants