Fix question author name when quoting to reply - #7798
Open
janbrasna wants to merge 1 commit into
Open
Conversation
escattone
reviewed
Aug 5, 2026
Contributor
There was a problem hiding this comment.
@janbrasna Hi Jan! Thanks! I just have some minor comments.
Comment on lines
+382
to
+383
| var authorEl = document.querySelector('.thread-post--author-name'); | ||
| var author = authorEl ? authorEl.textContent.trim() : ''; |
Contributor
There was a problem hiding this comment.
Two small things:
- It'd be nice to only do this work if we have to, so only when we know we're falling back.
- Should we trim the
nameEl.textContentas well?
Also, can you add a test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#3034
Ryan noticed this has to cater for both selectors, the one within the dataset reply ID which contains the answer author (also done with the same link functinon), and the broken author quoting where the author's elements (question headers) are currently moved outside of its dataset question ID and don't follow the previous class naming anyway.
So this now attempts to reach both element selector possibilities in a failover fashion.