-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Offload canvas drawing operations to a worker #20729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aditi-1400
wants to merge
14
commits into
mozilla:master
Choose a base branch
from
Aditi-1400:worker-drawing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
869490f
Extract ObjectHandler from WorkerTransport
Aditi-1400 fc719f7
[api-minor] Adds RendererWorker class for offloading canvas
Aditi-1400 f38b424
Detect TR-based canvas filters and report them to the display layer
Aditi-1400 138f157
Allow ObjectHandler to operate on a bare PDFObjects page cache
Aditi-1400 1aa13f7
Add object forwarding between main thread and renderer worker
Aditi-1400 bc5c0bc
Cache Path2D objects on the operator list
Aditi-1400 ff30337
Reuse existing annotation canvases in beginAnnotation
Aditi-1400 b600d5b
Execute operator lists in the renderer worker
Aditi-1400 b75c038
Send the operator list to the renderer worker
Aditi-1400 04bac49
Adapt the viewer for transferred canvases
Aditi-1400 236dc1b
Adapt the test harness for transferred canvases
Aditi-1400 ffdd906
Enable WebGPU in the renderer worker
Aditi-1400 312476e
[api-minor] Enable worker rendering
Aditi-1400 58eed71
Reduce the parsing overhead of hasCanvasFilters
Aditi-1400 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two loops look very similar, maybe we could have an helper function to avoid redundancy.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try doing that, in one of the earlier versions of the patch, I think this is probably the commit which captures the idea, later though I felt it added too much complexity and reduced readability of the code without significant returns, so I isolated them, let me know if you prefer extracting the common bits though, it should be a minimal effort to go back to that approach