Skip to content

Nova-ify the viewer (bug 2063405) - #21779

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:pdfjs_nova
Aug 15, 2026
Merged

Nova-ify the viewer (bug 2063405)#21779
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:pdfjs_nova

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

No description provided.

@calixteman

Copy link
Copy Markdown
Contributor Author

It has been visually validated by the UI/UX team and it's behind the nova pref I added recently.

@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (b96d745) to head (fd8ed84).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21779   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         264      264           
  Lines       67253    67253           
=======================================
+ Hits        60632    60633    +1     
+ Misses       6621     6620    -1     
Flag Coverage Δ
browsertest 66.33% <ø> (ø)
fonttest 9.00% <ø> (ø)
integrationtest 69.37% <ø> (+<0.01%) ⬆️
unittest 58.25% <ø> (-0.02%) ⬇️
unittestcli 56.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij

Copy link
Copy Markdown
Collaborator

/botio-linux preview

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/35eb913209ae126/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/35eb913209ae126/output.txt

Total script time: 1.40 mins

Published

@timvandermeij
timvandermeij merged commit 48bb93b into mozilla:master Aug 15, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

I've compared the new and old (regular) viewers, and spotted no differences as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants