Skip to content

Use Array.prototype.filter(Boolean) more, when filtering out truthy values - #21781

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:filter-Boolean
Aug 15, 2026
Merged

Use Array.prototype.filter(Boolean) more, when filtering out truthy values#21781
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:filter-Boolean

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

There are some spots where we want to filter out any truthy values, where that's currently done with an arrow function. Those cases can instead use Boolean as the callback function, which is a pattern that newer parts of the code-base is already using.

… values

There are some spots where we want to filter out any truthy values, where that's currently done with an arrow function. Those cases can instead use `Boolean` as the callback function, which is a pattern that newer parts of the code-base is already using.
@codecov-commenter

codecov-commenter commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (b96d745) to head (92b2cd3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21781   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         264      264           
  Lines       67253    67250    -3     
=======================================
+ Hits        60632    60635    +3     
+ Misses       6621     6615    -6     
Flag Coverage Δ
browsertest 66.35% <40.00%> (+0.02%) ⬆️
fonttest 9.00% <ø> (ø)
integrationtest 69.38% <60.00%> (+0.01%) ⬆️
unittest 58.26% <100.00%> (-0.01%) ⬇️
unittestcli 56.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/df35ad3abc52c28/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/521ecb2bac9772c/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/df35ad3abc52c28/output.txt

Total script time: 18.20 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/521ecb2bac9772c/output.txt

Total script time: 23.63 mins

  • Regression tests: Passed

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@timvandermeij
timvandermeij merged commit f4a73b3 into mozilla:master Aug 15, 2026
21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks better; thanks!

@Snuffleupagus
Snuffleupagus deleted the filter-Boolean branch August 15, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants