Use Array.prototype.filter(Boolean) more, when filtering out truthy values - #21781
Conversation
… values There are some spots where we want to filter out any truthy values, where that's currently done with an arrow function. Those cases can instead use `Boolean` as the callback function, which is a pattern that newer parts of the code-base is already using.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21781 +/- ##
=======================================
Coverage 90.15% 90.16%
=======================================
Files 264 264
Lines 67253 67250 -3
=======================================
+ Hits 60632 60635 +3
+ Misses 6621 6615 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/df35ad3abc52c28/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/521ecb2bac9772c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/df35ad3abc52c28/output.txt Total script time: 18.20 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/521ecb2bac9772c/output.txt Total script time: 23.63 mins
|
|
Looks better; thanks! |
There are some spots where we want to filter out any truthy values, where that's currently done with an arrow function. Those cases can instead use
Booleanas the callback function, which is a pattern that newer parts of the code-base is already using.