Use moz-l10n parsePattern with options - #4370
Open
ewerybody wants to merge 6 commits into
Open
Conversation
passing options to `parsePattern` now
setting `xliffIsXcode` to remain optional
fixed the `parsePattern` optionbag keys
added tests for Xcode variable replacement and the `escapeHTML` option
prettified
ewerybody
marked this pull request as ready for review
August 7, 2026 21:58
flodolo
reviewed
Aug 8, 2026
| "@fluent/react": "^0.15.1", | ||
| "@lezer/highlight": "^1.1.6", | ||
| "@mozilla/l10n": "^0.13.0", | ||
| "@mozilla/l10n": "^0.14.0", |
Collaborator
There was a problem hiding this comment.
Should we pick JS and Python in sync?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4362.
parsePatternuse options bag withxliffIsXcodeflagThe TypeScript check was failing as long as the fixed
moz-l10npackage was not yet published and the new version put into thetranslate/package.json.That's done now :)