Skip to content

Handle null consent state during appsflyer kit init when GDPR is enabled #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesnrokt merged 2 commits into from
May 27, 2026
Merged

Handle null consent state during appsflyer kit init when GDPR is enabled #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518ba45
Handle null consent state during GDPR init
ankitsingh08 May 21, 2026
4412a8c
test: assert no JSONException is logged on null ConsentState; idiomat…
jamesnrokt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/main/kotlin/com/mparticle/kits/AppsFlyerKit.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,23 +496,25 @@ class AppsFlyerKit :
AppsFlyerConsentValues.DENIED.consentValue -> adPersonalizationConsentValue = false
}

val clientConsentSettings = parseToNestedMap(consentState.toString())
consentState?.let { state ->
val clientConsentSettings = parseToNestedMap(state.toString())

parseConsentMapping(settings[CONSENT_MAPPING]).iterator().forEach { currentConsent ->
parseConsentMapping(settings[CONSENT_MAPPING]).iterator().forEach { currentConsent ->

val isConsentAvailable =
searchKeyInNestedMap(clientConsentSettings, key = currentConsent.key)
val isConsentAvailable =
searchKeyInNestedMap(clientConsentSettings, key = currentConsent.key)

if (isConsentAvailable != null) {
val isConsentGranted: Boolean =
JSONObject(isConsentAvailable.toString()).opt("consented") as Boolean
if (isConsentAvailable != null) {
val isConsentGranted: Boolean =
JSONObject(isConsentAvailable.toString()).opt("consented") as Boolean

when (currentConsent.value) {
"ad_storage" -> adStorageConsentValue = isConsentGranted
when (currentConsent.value) {
"ad_storage" -> adStorageConsentValue = isConsentGranted

"ad_user_data" -> adUserDataConsentValue = isConsentGranted
"ad_user_data" -> adUserDataConsentValue = isConsentGranted

"ad_personalization" -> adPersonalizationConsentValue = isConsentGranted
"ad_personalization" -> adPersonalizationConsentValue = isConsentGranted
}
}
}
}
Expand Down
102 changes: 102 additions & 0 deletions src/test/kotlin/com/mparticle/kits/AppsflyerKitTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.content.Context
import android.net.Uri
import com.appsflyer.AppsFlyerLib
import com.mparticle.MParticle
import com.mparticle.MParticle.LogLevel
import com.mparticle.MParticleOptions
import com.mparticle.commerce.CommerceEvent
import com.mparticle.commerce.Product
Expand All @@ -15,6 +16,7 @@ import com.mparticle.identity.IdentityApi
import com.mparticle.identity.MParticleUser
import com.mparticle.internal.CoreCallbacks
import com.mparticle.internal.CoreCallbacks.KitListener
import com.mparticle.internal.Logger
import org.json.JSONArray
import org.json.JSONException
import org.json.JSONObject
Expand Down Expand Up @@ -244,6 +246,106 @@ class AppsflyerKitTests {
Assert.assertEquals(false, notExpectedConsentKey3)
}

@Test
@Throws(Exception::class)
fun testSetConsentWhenGDPRAppliesWithoutConsentStateUsesDefaults() {
val map = HashMap<String?, String?>()
map["defaultAdStorageConsent"] = "Granted"
map["gdprApplies"] = "true"
map["consentMapping"] =
"[{\\\"jsmap\\\":null,\\\"map\\\":\\\"Performance\\\",\\\"maptype\\\":\\\"ConsentPurposes\\\",\\\"value\\\":\\\"ad_user_data\\\"},{\\\"jsmap\\\":null,\\\"map\\\":\\\"Marketing\\\",\\\"maptype\\\":\\\"ConsentPurposes\\\",\\\"value\\\":\\\"ad_personalization\\\"},{\\\"jsmap\\\":null,\\\"map\\\":\\\"testconsent\\\",\\\"maptype\\\":\\\"ConsentPurposes\\\",\\\"value\\\":\\\"ad_storage\\\"}]"
map["defaultAdUserDataConsent"] = "Denied"
map["defaultAdPersonalizationConsent"] = "Unspecified"

kit.configuration =
KitConfiguration.createKitConfiguration(JSONObject().put("as", map.toMutableMap()))

val method: Method =
AppsFlyerKit::class.java.getDeclaredMethod(
"setConsent",
ConsentState::class.java,
)
method.isAccessible = true
method.invoke(kit, null)

val afConsentResults = appsflyer.getConsentState()
Assert.assertEquals(true, afConsentResults["isUserSubjectToGDPR"])
Assert.assertEquals(false, afConsentResults["hasConsentForDataUsage"])
Assert.assertFalse(afConsentResults.containsKey("hasConsentForAdsPersonalization"))
Assert.assertEquals(true, afConsentResults["hasConsentForAdStorage"])
}

@Test
@Throws(Exception::class)
fun testSetConsentWhenGDPRAppliesWithoutConsentStateDoesNotLogJsonError() {
val map = HashMap<String?, String?>()
map["gdprApplies"] = "true"
map["defaultAdStorageConsent"] = "Granted"
map["consentMapping"] =
"[{\\\"jsmap\\\":null,\\\"map\\\":\\\"Marketing\\\",\\\"maptype\\\":\\\"ConsentPurposes\\\",\\\"value\\\":\\\"ad_personalization\\\"}]"

kit.configuration =
KitConfiguration.createKitConfiguration(JSONObject().put("as", map.toMutableMap()))

val errorLog = RecordingLogHandler()
Logger.setLogHandler(errorLog)
Logger.setMinLogLevel(LogLevel.ERROR, true)
try {
val method: Method =
AppsFlyerKit::class.java.getDeclaredMethod(
"setConsent",
ConsentState::class.java,
)
method.isAccessible = true
method.invoke(kit, null)
} finally {
Logger.setLogHandler(Logger.DefaultLogHandler())
}

Assert.assertNull(
"setConsent(null) must not invoke parseToNestedMap; got error: ${errorLog.lastError}",
errorLog.lastError,
)
}

private class RecordingLogHandler : Logger.AbstractLogHandler() {
var lastError: Throwable? = null

override fun isADBLoggable(
tag: String?,
logLevel: Int,
): Boolean = true

override fun verbose(
error: Throwable?,
message: String?,
) {}

override fun info(
error: Throwable?,
message: String?,
) {}

override fun debug(
error: Throwable?,
message: String?,
) {}

override fun warning(
error: Throwable?,
message: String?,
) {}

override fun error(
error: Throwable?,
message: String?,
) {
if (error != null) {
lastError = error
}
}
}

@Test
@Throws(Exception::class)
fun testConsentWhenGDPRAppliedWithConsentDefaults() {
Expand Down
Loading