Fix error message property in Mpdf.php#2043
Open
cebe wants to merge 1 commit into
Open
Conversation
Exception thrown on invalid UTF-8 input asks about property `in_charset`. The actual property name is `charset_in`.
cebe
changed the title
Member
|
Thanks for a PR. Please add a unit test covering this change. |
|
@finwe it looks like that is fix of mistype... and it stuck for ~2years |
Member
|
@chezinut It apparently was not critical enough for anybody to be fixed according to guidelines ~2years back. If it is for you, feel free to propose a PR with the test present. When the configuration property names change, this is a candidate to be overlooked again, so, with a test, that could be prevented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception thrown on invalid UTF-8 input asks about property
in_charset. The actual property name ischarset_in:https://github.com/cebe/mpdf/blob/dfb5346e2e7ffdb4b0f6d588e94629ad52fb3466/src/Mpdf.php#L529