Allow building on non-x86 systems - #91
Merged
Merged
Conversation
Signed-off-by: KP Choi <kp5.choi@samsung.com>
Signed-off-by: KP Choi <kp5.choi@samsung.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #87 by @scaronni — his commit is included as is. This adds native builds on ARM and a plain C fallback for any other architecture, so the library can be packaged from source without cross-compiling on x86.
Follow-up fixes on top:
amd64; the original regex missed Windows'AMD64/ARM64, which would silently drop all SIMD from MSVC builds.-DX86/-DARMon all platforms including MSVC; the-DARM=TRUEcross-build flow keeps working. This also removes the duplicate ARM block the patch added at the bottom of the top-level CMakeLists.Verified on x86-64 (SIMD kept) and with a forced riscv64 target for the plain C fallback, both profiles; decoded output bit-exact in all cases.
Closes #87