Fix VUI signaling in SPS - #168
Merged
Merged
Conversation
Signed-off-by: KP Choi <kp5.choi@samsung.com>
Signed-off-by: KP Choi <kp5.choi@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sps->vui_parameters_present_flagwas hardcoded to 0, so none of the VUIoptions (timing info, aspect ratio, color description, ...) ever reached the
bitstream. This enables it whenever any VUI field is actually requested;
default streams are unchanged.
Also fixed along the way:
num_units_in_tick = fps.num / fps.den,time_scale = 1). It now propagatesfps.den/fps.num, so-z 30000/1001 --units-in-tick 1001signals proper 29.97 timing withouthaving to spell out
--time-scale.--units-in-tick,--pic-struct,--chromaloc-tf/bf,--mv-over-pic-boundaries,--max-bits-per-cu-denom,--log2-max-mv-len-hor/ver,--neutral-chroma-flag,--frame-field-flag)were parsed into the args struct but never copied into the encoder
parameters, i.e. silently ignored. They are wired up now.
xeve_param_default()setvideoformatto 2 (NTSC) instead of 5(unspecified) and left the bitstream-restriction fields at 0 instead of
their spec defaults, which would have turned the VUI on for every stream.
--sar 1reproduces iton master) because the ERR path freed uninitialized image lists.
--sar,--videoformat,--colorprim, etc. now also accept plain numericvalues in addition to names.
Verified: default streams are bit-exact with master (SEI text aside); VUI is
written only when requested; timing/aspect streams decode fine with xevd;
both profiles build.
Addresses #133