Skip to content

Work around MSVC's C99 support#20

Closed
qi7chen wants to merge 2 commits intompx:masterfrom
qi7chen:msvc-fix
Closed

Work around MSVC's C99 support#20
qi7chen wants to merge 2 commits intompx:masterfrom
qi7chen:msvc-fix

Conversation

@qi7chen
Copy link
Copy Markdown
Contributor

@qi7chen qi7chen commented Dec 23, 2014

1, inline keyword is only available in C++, define to __inline instead.
2, Visual C++ doesn't supply snprintf and strncasecmp, define to _snprintf and _strnicmp instead.
3, define _CRT_SECURE_NO_WARNINGS to disable deprecation warnings.

inline ==> __inline
snprintf ==> _snprintf
strncasecmp ==> _strnicmp
@qi7chen
Copy link
Copy Markdown
Contributor Author

qi7chen commented Dec 23, 2014

Tested under Visual C++ 2012, Visual C++ 2013 with CMake 3.0

@qi7chen qi7chen mentioned this pull request Dec 23, 2014
@mpx
Copy link
Copy Markdown
Owner

mpx commented Aug 24, 2016

Thanks! I have merged these changes.

@mpx mpx closed this Aug 24, 2016
@spacewander
Copy link
Copy Markdown

spacewander commented Oct 10, 2016

Note that isnan is not supported yet under Visual C++ lower than 2013. Some of our windows servers are still running with it.
Still vote for #1 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants