Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero's buster could remain orange at full saber charge, and taking damage or switching characters could leave overlapping charge particles. This restores X3's original blue/purple/green body palettes and three charge-particle animations. The green flash remains after both beams while the saber is stored, then clears when used or cancelled.
Charge cancellation now retires class-1 effects across the complete native small-actor pool. Assets are extracted from the user's X3 ROM into a v7 cache; no ROM-derived art is distributed. The existing 40-byte save layout, charge thresholds, combo timing and X1 special-weapon upgrade requirements are preserved. This branch contains only the Zero follow-up.
Validation: visually compared original X3 and port captures; native/Python extraction parity including copier headers and invalid-ROM preservation; Zero/renderer CTests; ROM-backed charge checks without/with arms, stored saber, hurt, both swaps and deterministic replay. The existing complete Zero runtime suite also passed on the integrated development branch.
Fixes #55. Fixes #56.