fix(ci): unbreak the e2e build and the darwin vllm-metal pin - #11849
Merged
Conversation
Two independent breakages on master make every open pull request red, for reasons unrelated to the changes under review. The e2e backend suite stopped compiling. Reply.message is `bytes` in backend.proto, so res.GetMessage() returns []byte, and strings.ToUpper wants a string. Every other call site in the file already converts. tests/e2e-backends sits behind a build tag, so `go build ./...` never compiled it and the breakage reached master unnoticed. The darwin vllm build stopped resolving. Upstream vllm-metal deleted its old dev tags and re-versioned to track the vLLM release it targets, so the pinned wheel 404s. The coupled vLLM release also moved out of upstream's install.sh into .github/vllm-release-tag.commit, and the wheel's platform tag moved from macosx_11_0 to macosx_15_0. Read the wheel name from the release's own asset listing rather than composing it from a hardcoded platform segment, so a platform-tag change cannot silently 404 again, and resolve the vLLM version from the new metadata file with a fallback to the legacy installer. The bump script and the extractor learn the same two-source lookup, so the next nightly run converges on the pin checked in here instead of reintroducing the break. Assisted-by: Claude:claude-opus-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent breakages on master are making every open PR red for reasons unrelated to the change under review. Both are fixed here.
1. The e2e backend suite does not compile
9e831d770(#11840) landed this intests/e2e-backends/backend_test.go:476:Reply.messageisbytesinbackend/backend.proto:393, sores.GetMessage()returns[]byteandstrings.ToUpperwants astring. Every other call site in the same file already wraps it (lines 708, 711).This fails
tests-llama-cpp-smokeon every PR whose merge ref includes current master.tests/e2e-backendsis behind a build tag, so a normalgo build ./...never compiles it and the breakage reached master unnoticed.2. The darwin vllm build cannot resolve its wheel
VLLM_METAL_VERSION="v0.3.0.dev20260818075955"inbackend/python/vllm/install.shpoints at a release upstream has deleted. Verified today: the release API returns 404 and so does the wheel.Upstream re-versioned vllm-metal so its version tracks the vLLM release it targets, which broke three things at once:
v0.28.0andv0.28.0.dev*)install.shinto.github/vllm-release-tag.commit, so the extractor returns nothing even given a valid tagmacosx_11_0tomacosx_15_0Rather than just moving the pin, the wheel name is now read from the release's own asset listing instead of being composed from a hardcoded platform segment, so a future platform-tag change cannot silently 404. The vLLM version resolves from the new metadata file with a fallback to the legacy installer.
.github/bump_vllm_metal.shandscripts/lib/extract-vllm-metal-version.shlearn the same two-source lookup, so the next nightly bump converges on the pin checked in here rather than reintroducing the break.v0.28.0(the stable release, which/releases/latestreturns) is chosen over the newer dev tag deliberately: the dev tags are the ones upstream deletes and re-cuts.Verification
The wheel URL check runs the same resolution logic
install.shnow performs, end to end.🤖 Generated with Claude Code
https://claude.ai/code/session_01UxkheFa72CEpeEJbijyjxe