Skip to content

[docs][Table] Fix wrong number of rows reported to screen readers #47653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seomsoo wants to merge 5 commits into
base: master
Choose a base branch
from
+10 −4
Open

[docs][Table] Fix wrong number of rows reported to screen readers #47653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f526f71
fix(docs): prevent VoiceOver from skipping collapsible table rows
seomsoo Jan 18, 2026
317c748
fix(docs): avoid visual regression while fixing VoiceOver row skipping
seomsoo Jan 19, 2026
3f316a1
Merge branch 'master' into fix/voiceover-row-skip
mj12albert Mar 20, 2026
debf133
Merge branch 'master' into fix/voiceover-row-skip
seomsoo Aug 13, 2026
9e138c7
Simplify aria-hidden and link the expand button to the detail row
seomsoo Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/data/material/components/table/CollapsibleTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,16 @@ function createData(name, calories, fat, carbs, protein, price) {
function Row(props) {
const { row } = props;
const [open, setOpen] = React.useState(false);
const detailsId = React.useId();

return (
<React.Fragment>
<TableRow sx={{ '& > .MuiTableCell-root': { borderBottom: 'unset' } }}>
<TableCell>
<IconButton
aria-label="expand row"
aria-label={open ? 'collapse row' : 'expand row'}
aria-expanded={open}

@silviuaavram silviuaavram Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add aria-controls pointing to the row element which is controlled by this button.

aria-controls={detailsId}
size="small"
onClick={() => setOpen(!open)}
>
Expand All @@ -61,7 +64,7 @@ function Row(props) {
<TableCell align="right">{row.carbs}</TableCell>
<TableCell align="right">{row.protein}</TableCell>
</TableRow>
<TableRow>
<TableRow id={detailsId} aria-hidden={!open ? true : undefined}>
<TableCell style={{ paddingBottom: 0, paddingTop: 0 }} colSpan={6}>
<Collapse in={open} timeout="auto" unmountOnExit>
<Box sx={{ margin: 1 }}>
Expand Down
7 changes: 5 additions & 2 deletions docs/data/material/components/table/CollapsibleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,16 @@ function createData(
function Row(props: { row: ReturnType<typeof createData> }) {
const { row } = props;
const [open, setOpen] = React.useState(false);
const detailsId = React.useId();

return (
<React.Fragment>
<TableRow sx={{ '& > .MuiTableCell-root': { borderBottom: 'unset' } }}>
<TableCell>
<IconButton
aria-label="expand row"
aria-label={open ? 'collapse row' : 'expand row'}
aria-expanded={open}
aria-controls={detailsId}
size="small"
onClick={() => setOpen(!open)}
>
Expand All @@ -67,7 +70,7 @@ function Row(props: { row: ReturnType<typeof createData> }) {
<TableCell align="right">{row.carbs}</TableCell>
<TableCell align="right">{row.protein}</TableCell>
</TableRow>
<TableRow>
<TableRow id={detailsId} aria-hidden={!open ? true : undefined}>
<TableCell style={{ paddingBottom: 0, paddingTop: 0 }} colSpan={6}>
<Collapse in={open} timeout="auto" unmountOnExit>
<Box sx={{ margin: 1 }}>
Expand Down
Loading