Use UV to run generategraphclient#91
Conversation
|
@hemangandhi is this useful? |
hemangandhi
left a comment
hemangandhi
left a comment
There was a problem hiding this comment.
I think this is a good move but if @woswos wants to keep using venv, perhaps we should keep the old instructions too?
| ```bash | ||
| # delete the virtual environment | ||
| rm -rf ./.venv | ||
| PYTHONPATH=python uv run --with six==1.16.0 --with requests==2.27.1 --with graphql-core==3.2.0 --with typing_extensions==4.2.0 --with websockets==16.0 devbin/mujin_webstackclientpy_generategraphclient.py --url http://controller123 > python/mujinwebstackclient/webstackgraphclient.py |
There was a problem hiding this comment.
- Can we break this command into multiple lines?
- Is ``PYTHONPATH=python really needed?
There was a problem hiding this comment.
Is
PYTHONPATH=pythonreally needed
yes, it replaces install .
Can we break this command into multiple lines?
as far as I investigate, it is not possible, the most realistic alternative is to migrate our code base to pyproject.toml or requirements.txt, but it also requires dropping distutils1
Footnotes
-
mujinsimulator already dropped distutils jfyi ↩
There was a problem hiding this comment.
Can we break this command into multiple lines?
No, I just meant adding \ to make it easier to read the command in the readme file. Something like:
PYTHONPATH=python uv run \
--with six==1.16.0 \
--with requests==2.27.1 \
--with graphql-core==3.2.0 \
--with typing_extensions==4.2.0 \
--with websockets==16.0 \
devbin/mujin_webstackclientpy_generategraphclient.py --url http://controller123 > python/mujinwebstackclient/webstackgraphclient.py
There was a problem hiding this comment.
Actually it turned out mujincommon.setuptools.Distribution works on setuptools, so I post #92
|
postponing this pull request until we drop distutils at least in this repository. |
3 participants
No description provided.