fix: Rerun workflow docs - #196
Conversation
Events like ready_for_review, labeled, and unlabeled fire without changing the head SHA, so a single commit can accumulate multiple 'Run Codeowners Plus' check runs. With cancel-in-progress: true, rerun-checks v3.1.0 (which now re-runs all matching check runs) triggers duplicates that cancel each other, and the cancelled run reads as a codeowners-plus failure — blocking CI when the check is required. Queue runs instead of cancelling them. Fixes #195 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment why cancel-in-progress stays false, note that the rerun workflow's check-names must match the codeowners job name, and fix the rerun-checks digest comment to its actual tag (v3.1.0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md file. It modifies a GitHub Actions workflow example to set cancel-in-progress to false under concurrency to queue duplicate runs, and adds a note clarifying that the rerun workflow's check-names must exactly match the job name in the codeowners workflow to avoid silent failures. There are no review comments, so I have no feedback to provide.
|
Codeowners approval required for this PR: |
Confidence Score: 4/5The PR should not merge until the concurrency configuration handles bursts without cancelling pending required-check runs. The changed setting prevents cancellation of the active run but still allows an older pending run to be cancelled when several pull-request events arrive for the same ref, preserving the merge-blocking failure the PR intends to remove. Files Needing Attention: .github/workflows/codeowners.yml and the matching README example
|
| Filename | Overview |
|---|---|
| .github/workflows/codeowners.yml | Disables active-run cancellation, but GitHub’s single pending concurrency slot leaves cancellation-related failed checks reachable during bursts of events. |
| .github/workflows/rerun_codeowners.yml | Updates only the version annotation for an unchanged pinned action revision. |
| README.md | Accurately documents check-name coupling but overstates cancel-in-progress false as fully queueing duplicate runs. |
Reviews (1): Last reviewed commit: "docs: clarify concurrency choice and rer..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| group: codeowners-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| # queue duplicate runs - cancelled runs read as a failed check (#195) | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
If three or more pull-request events arrive while the first run is executing, GitHub retains only one pending run and cancels the older pending run, causing the cancellation-related failed required check that this change intends to prevent.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Related Issue(s)