Refactor internal snapshot state - #409
Open
maarten-ic wants to merge 1 commit into
Open
Conversation
- Create CommunicatorState which captures both the `port_message_counts` and `timeline_state`. This will store the message cache (for repeated messages) as well in the future - Store CommunicatorState before calling pre-receive, instead of trying to correct the state after the pre-receive
IrisvdWerf
reviewed
Aug 28, 2026
|
|
||
| Args: | ||
| state: The state to restore, as returned by get_state(). | ||
| """ |
Collaborator
There was a problem hiding this comment.
Update this docstring, as this also includes the message counts?
LourensVeen
approved these changes
Aug 28, 2026
LourensVeen
left a comment
LourensVeen
left a comment
Contributor
There was a problem hiding this comment.
I like the concept, and it looks cleaner, so nice! Also I agree with Iris about that comment, otherwise let's go 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port_message_countsandtimeline_state. This will store the message cache (for repeated messages) as well in the future