Skip to content

Add checks for conduit filter order #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maarten-ic wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add checks for conduit filter order #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ymmsl/v0_2/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,21 @@ def __init__(
self.__check_reference(self.sender)
self.__check_reference(self.receiver)

# Check if filters are in the correct order:
err_msg = None
for i in range(len(self.filters) - 1):
pair = self.filters[i : i + 2]
if pair == [ConduitFilter.REPEAT, ConduitFilter.LAST]:
err_msg = "'repeat' filter must come after 'last'"
break
if pair == [ConduitFilter.PAD, ConduitFilter.LAST]:
err_msg = "'pad' filter must come after 'last'"
break
if pair == [ConduitFilter.PAD, ConduitFilter.REPEAT]:
err_msg = "'pad' filter must come after 'repeat'"
if err_msg is not None:
raise RuntimeError(f"Invalid conduit filter for {self}: {err_msg}.")

def __str__(self) -> str:
"""Return a string representation of the object."""
if not self.filters:
Expand Down
15 changes: 15 additions & 0 deletions ymmsl/v0_2/tests/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,21 @@ def test_conduit_filter() -> None:
assert ConduitFilter.PAD.is_repeater()


def test_conduit_order() -> None:
Conduit("a", "b", "last last")
Conduit("a", "b", "last pad")
Conduit("a", "b", "last repeat")
Conduit("a", "b", "repeat repeat")
Conduit("a", "b", "repeat pad")
Conduit("a", "b", "pad pad")
with pytest.raises(RuntimeError):
Conduit("a", "b", "repeat last")
with pytest.raises(RuntimeError):
Conduit("a", "b", "pad last")
with pytest.raises(RuntimeError):
Conduit("a", "b", "pad repeat")


def test_conduit_access() -> None:
conduit = Conduit("macro.out", "micro.in")

Expand Down