Repository navigation
chore(ci): replace the CODEOWNERS catch-all with a selective gate - #58
Open
justinmerrell wants to merge 1 commit into
Open
justinmerrell wants to merge 1 commit into
justinmerrell wants to merge 1 commit into
Conversation
Drop `* @musher-dev/engineering` (COMM-09) and own only the gate (/.github/, /.repo/) plus the two paths that run in every repository built from this container: the local mise Feature and the lifecycle scripts. Pin and lock files stay unowned so Dependabot merges on green. Fixes #54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
* @musher-dev/engineeringcatch-all in.github/CODEOWNERSwith the selective gate (platform ADR 0134; engineering-conventions COMM-09), first applied in musher-dev/host-images#71.Owned paths, all
@musher-dev/engineering:/.github//.repo/repopolicies/.devcontainer/features/mise//.devcontainer/scripts/Everything else is unowned on purpose. The issue asked for "the image-pin paths"; since decision 0004 there is no image of our own, and the remaining pins (
devcontainer.jsonFeatures,devcontainer-lock.json,.config/mise/, the stack compose files) are what Dependabot bumps, so they stay unowned and those PRs merge on green CI. The header comment says what is owned and why.docs/configuration.md's layout line forCODEOWNERSsaid "Every path: @musher-dev/engineering"; it now names the selective gate.Owner access
@musher-dev/engineeringnow haspushon this repository (gh api repos/musher-dev/development-container/teams), so the team is kept as owner rather than falling back to@justinmerrell.Verification
gh api "repos/musher-dev/development-container/codeowners/errors?ref=chore/codeowners-selective-gate" --jq .errorsreturns[].*line remains; every root-anchored path exists (COMM-10).conventions checkat 0.9.2 reports COMM-09 onmainand no COMM finding on this branch.repo check, markdownlint, codespell, committed).Note: the committed
.github/rulesets/main-branch.jsonsetsrequired_approving_review_count: 1; the issue's standard pairs0withrequire_code_owner_review: true. That ruleset is applied by infra-github and is not live here yet, so it is left for that change.Fixes #54
🤖 Generated with Claude Code