Skip to content

chore(ci): replace the CODEOWNERS catch-all with a selective gate - #58

Open
justinmerrell wants to merge 1 commit into
mainfrom
chore/codeowners-selective-gate
Open

justinmerrell wants to merge 1 commit into
mainfrom
chore/codeowners-selective-gate

Conversation

@justinmerrell

Copy link
Copy Markdown
Contributor

Summary

Replaces the * @musher-dev/engineering catch-all in .github/CODEOWNERS with the selective gate (platform ADR 0134; engineering-conventions COMM-09), first applied in musher-dev/host-images#71.

Owned paths, all @musher-dev/engineering:

Path Why
/.github/ The gate itself: this file, the rulesets, the workflows that run the required checks, the Dependabot config
/.repo/ The declarations, the waivers that silence this repository's own findings, and the repo policies
/.devcontainer/features/mise/ The local Feature that downloads and installs mise as root in every repository built from this container
/.devcontainer/scripts/ The lifecycle scripts every repository's container runs, including the GitHub credential and npm registry setup

Everything else is unowned on purpose. The issue asked for "the image-pin paths"; since decision 0004 there is no image of our own, and the remaining pins (devcontainer.json Features, devcontainer-lock.json, .config/mise/, the stack compose files) are what Dependabot bumps, so they stay unowned and those PRs merge on green CI. The header comment says what is owned and why.

docs/configuration.md's layout line for CODEOWNERS said "Every path: @musher-dev/engineering"; it now names the selective gate.

Owner access

@musher-dev/engineering now has push on this repository (gh api repos/musher-dev/development-container/teams), so the team is kept as owner rather than falling back to @justinmerrell.

Verification

  • gh api "repos/musher-dev/development-container/codeowners/errors?ref=chore/codeowners-selective-gate" --jq .errors returns [].
  • No * line remains; every root-anchored path exists (COMM-10).
  • conventions check at 0.9.2 reports COMM-09 on main and no COMM finding on this branch.
  • Pre-commit and commit-msg hooks passed (repo check, markdownlint, codespell, committed).

Note: the committed .github/rulesets/main-branch.json sets required_approving_review_count: 1; the issue's standard pairs 0 with require_code_owner_review: true. That ruleset is applied by infra-github and is not live here yet, so it is left for that change.

Fixes #54

🤖 Generated with Claude Code

Drop `* @musher-dev/engineering` (COMM-09) and own only the gate
(/.github/, /.repo/) plus the two paths that run in every repository
built from this container: the local mise Feature and the lifecycle
scripts. Pin and lock files stay unowned so Dependabot merges on green.

Fixes #54

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(codeowners): the owning team has no access, and * is a catch-all

1 participant