Skip to content

Veronicae/update#877

Open
HappyViki wants to merge 25 commits intomasterfrom
veronicae/update
Open

Veronicae/update#877
HappyViki wants to merge 25 commits intomasterfrom
veronicae/update

Conversation

@HappyViki
Copy link
Copy Markdown
Collaborator

@HappyViki HappyViki commented Jul 1, 2020

My concern: everything in package-lock.json got updated and I don't know if it's supposed to do that.

What I did:

  1. Started coding at c17feed
  2. Reinstalled jest@24.7.1 in root
  3. Reinstalled webpack-dev-server@latest in docs
  4. Ran eslint src --fix to fix all warnings
  5. Updated deprecated config option setupTestFrameworkScriptFile to setupFilesAfterEnv, with input string to array

How I reinstalled:

rm -rf node_modules && rm package-lock.json
npm uninstall --save-dev jest
npm install --save-dev jest@24.7.1
cd docs
rm -rf node_modules && rm package-lock.json
npm uninstall --save-dev webpack-dev-server
npm install --save-dev webpack-dev-server@latest

@HappyViki HappyViki self-assigned this Jul 1, 2020
@HappyViki HappyViki requested a review from sambev July 1, 2020 17:50
Comment thread docs/package.json Outdated
Comment thread docs/package.json
"@babel/polyfill": "^7.10.1",
"@babel/preset-env": "^7.10.2",
"@babel/preset-react": "^7.10.1",
"@babel/cli": "^7.1.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused by this, but it might just be me. In your package.json it says 7.1, but in the lock file it still has 7.10?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this as well. I did this:

rm -rf node_modules && rm package-lock.json
npm install
cd docs
rm -rf node_modules && rm package-lock.json
npm install

And it's still like that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is due to semantic versioning since we are using the ^. Lets just note that and move on with testing.

Comment thread package.json Outdated
@HappyViki HappyViki requested a review from phantomxc July 6, 2020 21:55
@HappyViki
Copy link
Copy Markdown
Collaborator Author

Moment has been locked to v2.22.2

@HappyViki
Copy link
Copy Markdown
Collaborator Author

HappyViki commented Jul 8, 2020

Commands For Testing Moment Fix

Symlink this

Switch to master for 8.1.0 and veronicae/update for 8.1.1

cd ~/mx-react-components/docs
rm -rf node_modules && npm install
cd ~/mx-react-components
rm -rf node_modules && npm run release
rm -rf ~/raja/node_modules/mx-react-components && cp -R ~/mx-react-components ~/raja/node_modules
cd ~/raja
rm -rf build && npm run compile:prod

Boot up firefly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants