Conversation
sambev
reviewed
Jul 2, 2020
sambev
reviewed
Jul 2, 2020
| "@babel/polyfill": "^7.10.1", | ||
| "@babel/preset-env": "^7.10.2", | ||
| "@babel/preset-react": "^7.10.1", | ||
| "@babel/cli": "^7.1.0", |
Contributor
There was a problem hiding this comment.
I am a little confused by this, but it might just be me. In your package.json it says 7.1, but in the lock file it still has 7.10?
Collaborator
Author
There was a problem hiding this comment.
I'm confused by this as well. I did this:
rm -rf node_modules && rm package-lock.json
npm install
cd docs
rm -rf node_modules && rm package-lock.json
npm install
And it's still like that.
Contributor
There was a problem hiding this comment.
I think it is due to semantic versioning since we are using the ^. Lets just note that and move on with testing.
…act-components into veronicae/update
added 2 commits
July 7, 2020 14:52
Collaborator
Author
|
|
Collaborator
Author
Commands For Testing Moment FixSwitch to master for 8.1.0 and veronicae/update for 8.1.1 Boot up firefly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My concern: everything in package-lock.json got updated and I don't know if it's supposed to do that.
What I did:
jest@24.7.1in rootwebpack-dev-server@latestin docseslint src --fixto fix all warningssetupTestFrameworkScriptFiletosetupFilesAfterEnv, with inputstringtoarrayHow I reinstalled: