Skip to content

fix: retry incomplete blob downloads after sync #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbenhagen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: retry incomplete blob downloads after sync #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
068dc60
fix: retry incomplete blob downloads after sync
cbenhagen Mar 31, 2026
e72b3e0
perf: debounce and back off the after-sync incomplete-blob re-scan
cbenhagen Jul 1, 2026
43c459f
fix: retry a failed download once with providers signalled while it ran
cbenhagen Sep 8, 2026
3389481
fix: fetch content for a remote entry from a provider that already si…
cbenhagen Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ impl Engine {
///
/// This will spawn two tokio tasks for the live sync coordination and gossip actors, and a
/// thread for the actor interacting with doc storage.
#[allow(clippy::too_many_arguments)]
pub async fn spawn(
endpoint: Endpoint,
gossip: Gossip,
Expand All @@ -68,6 +69,7 @@ impl Engine {
downloader: Downloader,
default_author_storage: DefaultAuthorStorage,
protect_cb: Option<ProtectCallbackHandler>,
incomplete_blob_check_interval: Option<std::time::Duration>,
) -> anyhow::Result<Self> {
let (live_actor_tx, to_live_actor_recv) = mpsc::channel(ACTOR_CHANNEL_CAP);
let me = endpoint.id().fmt_short().to_string();
Expand Down Expand Up @@ -122,6 +124,7 @@ impl Engine {
to_live_actor_recv,
live_actor_tx.clone(),
sync.metrics().clone(),
incomplete_blob_check_interval,
)?;
let actor_handle = n0_future::task::spawn(
async move {
Expand Down
Loading