Annotate the always-true condition in func_802B4104 - #771
Open
quarrel07 wants to merge 1 commit into
Open
Conversation
Collaborator
|
oops, I didn't see this PR. But I pushed comments for the bugs except the first one iirc. |
quarrel07
force-pushed
the
bug-annotations
branch
from
August 2, 2026 06:28
ff94404 to
834a2ee
Compare
quarrel07
changed the title
Contributor
Author
|
No problem. I rebased this down to just the first one, the other two are covered 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents one vanilla condition in
func_802B4104(blue/red shells) that never does what it looks like it does. Both branches use||where an&&band around zero was likely intended, so the first branch's second test is true for every value and the second branch's is redundant.Rebased down from the original three sites: the triple shell arcs and the Banshee Boardwalk lamp range are already covered on master by #778 and #779.
Comment-only change, so the preprocessed output is byte-identical and matching is unaffected.