-
Notifications
You must be signed in to change notification settings - Fork 16
feat: materialize canonicality in the index, expose in omnigraph #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
95f2e2a
feat: update abis to latest
shrugs c2404ef
checkpoint: initial canonicality implementation
shrugs 3b8eeca
feat: expose canonicality in omnigraph
shrugs 4537ed6
test: assert canonicality field on Domain and Registry
shrugs 1426de2
fix: bot review feedback (greploop iter 1)
shrugs 9e8b6fa
test: align integration tests with materialized canonical model
shrugs 5995fc2
fix: bot review feedback (greploop iter 2)
shrugs aad2f1c
fix: re-add MAX_DEPTH guard to getCanonicalPath
shrugs 499a2f4
docs: note that TOCTOU is not a concern inside Ponder event handlers
shrugs 3149920
checkpoint: pre-canonicality parallel table extraction
shrugs 856d30e
checkpoint: post parallel refactor, pre-reconciliation
shrugs fd0bc68
checkpoint: canonicality refactor testing
shrugs 11e582d
feat: fixup tests
shrugs 2ad23ae
fix: regenerate gqlschema
shrugs 4bc1b48
fix: address bot review feedback (loop 1)
shrugs daaf3ea
fix: changeset
shrugs 264af22
fix: use maybeGetENSv2RootRegistryId for v1-only namespaces
shrugs cc60281
checkpoint: custom sql
shrugs bcf0ef8
docs: address bot review feedback on canonicality docstrings
shrugs 56b1765
docs: address remaining bot review feedback
shrugs 57bc265
docs: changeset for @ensnode/ensnode-sdk breaking changes
shrugs ce477b0
feat(ensapi)!: drop DomainsWhereInput.canonical filter
shrugs 7bec55d
fix: update comments and gate bridged resolver canonicality
shrugs 7c1bc5c
fix: update comments
shrugs 76fc32b
docs: address remaining bot review nits
shrugs df23444
fix: address bot review nits + memoize bridged resolver configs
shrugs 82e3898
refactor: collapse bridged resolver config cache into single function
shrugs e77f7fc
fix: remove unnecessary changeset
shrugs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensapi": minor | ||
| --- | ||
|
|
||
| **Omnigraph**: expose `Domain.canonical` and `Registry.canonical` on the Omnigraph schema. Both are non-null `Boolean!` fields indicating whether the entity participates in the Canonical Nametree. | ||
|
shrugs marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensapi": minor | ||
| --- | ||
|
|
||
| **Omnigraph (breaking)**: drop the `canonical: Boolean = false` field from `DomainsWhereInput` (used by `Query.domains`). Every nameable Domain is canonical by definition, so the filter was redundant; the query now always scopes to Canonical Domains. Consumers passing `where: { canonical: true }` should drop the field; consumers relying on `canonical: false` (or default) to surface non-canonical Domains via this query no longer can — read `Domain.canonical` directly or scope by `Account.domains` / `Registry.domains` instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@ensnode/ensnode-sdk": minor | ||
| --- | ||
|
|
||
| **Breaking (`@ensnode/ensnode-sdk`)**: `getRootRegistryIds` is removed; use the new `isRootRegistryId(namespace, registryId)` predicate to test root membership instead. `getRootRegistryId` (singular, "preferred root") is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensapi": minor | ||
| --- | ||
|
|
||
| **Omnigraph (breaking)**: `Resolver.bridged` is no longer an `AccountId` scalar; it now returns the bridged target `Registry` interface. Consumers should change their selection from `bridged` (scalar) to `bridged { ... }` (Registry interface) — the new shape exposes the full `Registry` and allows navigation into the bridged sub-registry's canonical Domain etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| /** | ||
| * The maximum depth of a name supported by Omnigraph traversal libs, to avoid runaway walks across | ||
| * the namegraph. ENS names have no formal depth limit, but we cap traversal to fail loudly rather | ||
| * than risk an unbounded recursive CTE. | ||
| * | ||
| * If this depth turns out to be problematic in practice, we can increase it as necessary. | ||
| */ | ||
| export const MAX_SUPPORTED_NAME_DEPTH = 16; |
69 changes: 0 additions & 69 deletions
69
apps/ensapi/src/omnigraph-api/lib/find-domains/canonical-registries-cte.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.