Skip to content

chore: remove TODOs in examples/ apps#2169

Open
sevenzing wants to merge 1 commit into
mainfrom
ll/remove-todos-in-examples
Open

chore: remove TODOs in examples/ apps#2169
sevenzing wants to merge 1 commit into
mainfrom
ll/remove-todos-in-examples

Conversation

@sevenzing
Copy link
Copy Markdown
Member

Summary

Remove example apps. see #2167 for more details

Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

@sevenzing sevenzing requested a review from a team as a code owner May 21, 2026 12:39
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 21, 2026 12:39pm
3 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 21, 2026 12:39pm
ensnode.io Skipped Skipped May 21, 2026 12:39pm
ensrainbow.io Skipped Skipped May 21, 2026 12:39pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

⚠️ No Changeset found

Latest commit: 83b6a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@sevenzing has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 45 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dc6524ec-12ad-48e6-b9cd-90d52ba2121c

📥 Commits

Reviewing files that changed from the base of the PR and between 8220c38 and 83b6a13.

📒 Files selected for processing (5)
  • examples/enskit-react-example/src/AccountView.tsx
  • examples/enskit-react-example/src/DomainView.tsx
  • examples/enskit-react-example/src/SearchView.tsx
  • examples/enssdk-example/src/index.ts
  • examples/omnigraph-graphql-example/src/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ll/remove-todos-in-examples

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Greptile Summary

This PR removes stale TODO comments from example apps across three directories — enskit-react-example, enssdk-example, and omnigraph-graphql-example. All TODOs referenced a pending upgrade of v2-sepolia to include materialized canonical names; removing them cleans up the examples without touching any executable logic.

  • Deleted TODO comment blocks in GraphQL fragments, TypeScript interfaces, and React components that described a future migration to canonical { name { interpreted } } fields.
  • Removed a single // TODO: render the set of tlds comment in DomainView.tsx; the surrounding redirect logic is unchanged.

Confidence Score: 5/5

All changes are comment-only deletions in example apps; no runtime behavior is affected and nothing in the library or production code is touched.

Every line removed is a comment or commented-out code block. The executable code in all five files is identical before and after the diff, making regressions essentially impossible.

No files require special attention.

Important Files Changed

Filename Overview
examples/enskit-react-example/src/AccountView.tsx Removes TODO comments referencing a pending v2-sepolia canonical name upgrade; no logic changes.
examples/enskit-react-example/src/DomainView.tsx Removes TODO comments for canonical name migration and a TLD rendering note; no behavior changes.
examples/enskit-react-example/src/SearchView.tsx Removes TODO comments related to canonical name GraphQL fields; no logic changes.
examples/enssdk-example/src/index.ts Removes TODO comments for canonical name migration in GraphQL fragment and formatDomain helper; no logic changes.
examples/omnigraph-graphql-example/src/index.ts Removes TODO comments for canonical name fields in the GraphQL query, TypeScript interface, and formatDomain helper; no logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Remove TODOs in examples/] --> B[enskit-react-example]
    A --> C[enssdk-example]
    A --> D[omnigraph-graphql-example]

    B --> E[AccountView.tsx\n– remove canonical name TODO in GQL + JSX]
    B --> F[DomainView.tsx\n– remove canonical name TODOs + TLD TODO]
    B --> G[SearchView.tsx\n– remove canonical name TODO in GQL + JSX]

    C --> H[index.ts\n– remove canonical name TODO in fragment + formatDomain]

    D --> I[index.ts\n– remove canonical name TODOs in query,\ninterface, and formatDomain]

    E & F & G & H & I --> J[No logic changes\nComment-only deletions]
Loading

Reviews (1): Last reviewed commit: "remove TODOs in examples/ apps" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant