Skip to content

docs(ensnode.io): brighten caution aside yellow and split accent from…#2218

Merged
lightwalker-eth merged 3 commits into
mainfrom
docs/caution-aside-yellow
May 29, 2026
Merged

docs(ensnode.io): brighten caution aside yellow and split accent from…#2218
lightwalker-eth merged 3 commits into
mainfrom
docs/caution-aside-yellow

Conversation

@notrab
Copy link
Copy Markdown
Member

@notrab notrab commented May 28, 2026

… background

Lite PR

Tip: Review docs on the ENSNode PR process

Summary

  • What changed (1-3 bullets, no essays).

Why

  • Why this change exists. Link to related GitHub issues where relevant.

Testing

  • How this was tested.
  • If you didn't test it, say why.

Notes for Reviewer (Optional)

  • Anything non-obvious or worth a heads-up.

Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

Copilot AI review requested due to automatic review settings May 28, 2026 15:11
@notrab notrab requested a review from a team as a code owner May 28, 2026 15:11
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 29, 2026 8:00am
ensnode.io Ready Ready Preview, Comment May 29, 2026 8:00am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 29, 2026 8:00am
ensrainbow.io Skipped Skipped May 29, 2026 8:00am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4bcee2e4-468b-4533-aca4-8e6c2035d078

📥 Commits

Reviewing files that changed from the base of the PR and between 11bf166 and 1128db6.

📒 Files selected for processing (1)
  • docs/ensnode.io/src/styles/starlight.css

📝 Walkthrough

Walkthrough

This PR refactors the Starlight theme's aside component styling in a single CSS file. The changes consolidate duplicated aside variant styles by introducing a shared --aside-color-driven pattern in the base .starlight-aside block, updating the caution color token, and simplifying the tip, danger, caution, and note variants to rely on centralized styling.

Changes

Starlight Aside Styling Refactor

Layer / File(s) Summary
Caution color token update
docs/ensnode.io/src/styles/starlight.css
Theme token --aside-caution-color is updated and --color-yellow-700 is added, establishing the color foundation for the caution variant.
Base aside styling refactor
docs/ensnode.io/src/styles/starlight.css
Base .starlight-aside block refactored to centralize border, background, icon, link, and code styling derived from --aside-color, including unified mixed code background and shared code border radius.
Variant consolidation
docs/ensnode.io/src/styles/starlight.css
Aside variants (tip, danger, caution, note) now set --aside-color and optional text/code overrides, relying on the shared base styling; variant-specific rules mainly affect sl-link-card:hover title/icon coloring, with caution providing additional code/pre overrides.

Possibly Related PRs

  • namehash/ensnode#2215: Overlaps directly on refactoring .starlight-aside and .sl-link-card:hover styling via shared --aside-color-derived variables.
  • namehash/ensnode#2201: Both PRs modify the same starlight.css file and update aside-related CSS variables/selectors, including code/background and derived styling changes.
  • namehash/ensnode#2151: Updates to starlight.css that affect aside/link styling and overlap with variant/link-card adjustments.

Suggested Labels

docs

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 In fields of CSS I hop and mend,
One color shared from end to end.
Variants trimmed, the rules align —
A tidy aside, a cleaner design.
✨🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description follows the required template structure with all major sections present, but the Summary and Why sections are incomplete and lack specific details about the actual changes. Fill in the Summary section with 1-3 bullets describing what changed, and the Why section with the rationale for the styling changes and any related issues.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: brightening the caution aside yellow and separating accent from background in the CSS styling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/caution-aside-yellow

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Greptile Summary

This PR makes two related improvements to the aside component styling in the ENSNode docs site: it brightens the caution aside's accent color from #ca8a04 to #eab308, and refactors all four aside variants (tip, danger, caution, note) to share common border/background/icon/link styles via a --aside-color CSS custom property on the base .starlight-aside class instead of repeating those declarations per variant.

  • Color split for caution: A separate --color-yellow-700: #a16207 token is introduced and applied as --aside-text-color for the caution variant, so the brighter #eab308 accent is used for backgrounds/borders while the darker #a16207 is used for icon and link text — preserving readability.
  • DRY refactor: Common border, background-color, icon, a, and code styles are lifted into .starlight-aside, with per-variant classes now only needing to set --aside-color (and optional overrides like --aside-code-strength).

Confidence Score: 5/5

Safe to merge — scoped entirely to CSS styling for the docs site with no logic or data changes.

The change touches only one CSS file, refactoring repetitive aside-variant rules into a shared base class and tweaking a single color token. The caution variant correctly introduces a separate darker text-color token to maintain readability against the brighter accent. No regressions to logic, APIs, or data are possible.

No files require special attention.

Important Files Changed

Filename Overview
docs/ensnode.io/src/styles/starlight.css Refactors aside variant styles to use a shared --aside-color CSS variable pattern, brightens the caution accent to #eab308, and adds a darker --color-yellow-700 token for caution text contrast. Clean, well-structured change with no functional regressions.

Reviews (3): Last reviewed commit: "color-yellow-700" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the docs site's caution aside styling to improve visual distinction by darkening the accent color and introducing a separate yellow background token used for the aside background, inline code, and pre blocks.

Changes:

  • Darken --aside-caution-color from #ca8a04 to #a16207.
  • Add --aside-caution-bg-color: #fde047 token.
  • Use the new background token for caution aside background, code, and pre backgrounds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 28, 2026

⚠️ No Changeset found

Latest commit: 1128db6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread docs/ensnode.io/src/styles/starlight.css
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Looks great, thank you. Please take the lead to merge when ready 👍

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@lightwalker-eth lightwalker-eth merged commit 3e2bbfd into main May 29, 2026
21 checks passed
@lightwalker-eth lightwalker-eth deleted the docs/caution-aside-yellow branch May 29, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants