fix image markdown format [ -> ( for 0.9.0 release notes - #447
Conversation
|
|
||
| </footer> | ||
| </body> | ||
| </html> No newline at end of file |
There was a problem hiding this comment.
why did this happen? I swear it wasn't Windows I used the online editor....
There was a problem hiding this comment.
Clearly the online editor did it and adds trailing newlines, while the generator doesn't. Shouldn't make any difference at all.
| bearings in seconds. If the viewer is empty, napari opens the built-in <em>Balls | ||
| (3D)</em> sample data so the walkthrough has something to show (<a class="reference external" href="https://github.com/napari/napari/pull/9290">#9290</a>).</p> | ||
| <p>![Screenshot of the napari viewer guided tour][../_static/images/guided-tour.png)</p> | ||
| <p></p> |
There was a problem hiding this comment.
LOL it's html at this point, it only looks like markdown because it didn't render to html. See e.g. line 856:
<p><img alt="napari screenshot showing inherited labeled viewer axes" src="../_images/axis-labels.png" /></p>So this should be:
| <p></p> | |
| <p><img alt="Screenshot of the napari viewer guided tour" src="../_static/images/guided-tour.png" /></p> |
Note also the change from _static/images to _images, which I don't understand. Clearly there is a build step changing that and copying the images somewhere... CC @melissawm 🤔
But it looks like _static/images are still there, as both of these work:
https://napari.org/stable/_static/images/axis-labels.png
https://napari.org/stable/_images/axis-labels.png
In this case, the file (guided-tour.png) wasn't copied, I presume because there was no link to it, so I'm leaving it as _static/images. Would be good to understand this all better though. I don't like that the images are being duplicated! (If that's indeed what's happening...)
There was a problem hiding this comment.
I'll take a look, but I'm pretty sure that's just how myst/sphinx builds the html pages - it dumps all images into the _images folder just like it creates _downloads, _modules, _sources etc. So if you are using the image in markdown, you use the path defined in the sources; if you are using raw html, that gets rendered just at the end after the build is finished, which means you have to use the html path (_images). But I may be wrong!
|
|
||
| </footer> | ||
| </body> | ||
| </html> No newline at end of file |
There was a problem hiding this comment.
Clearly the online editor did it and adds trailing newlines, while the generator doesn't. Shouldn't make any difference at all.
3 participants
xref napari/docs#1123