a11y(batch): CertSwitcher aria-hidden + design-token contrast verification - #228
Open
nastaso wants to merge 1 commit into
Open
a11y(batch): CertSwitcher aria-hidden + design-token contrast verification#228nastaso wants to merge 1 commit into
nastaso wants to merge 1 commit into
Conversation
The active state is already conveyed by aria-current="true" on the parent button, so the check mark carries no independent information for screen-reader users. Closes #95.
Deploying cloudcertprep with
|
| Latest commit: |
79ae332
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e74d7348.cloudcertprep.pages.dev |
| Branch Preview URL: | https://fix-a11y-batch.cloudcertprep.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #95, closes #23.
#95 -
src/components/CertSwitcher.tsx:209: addsaria-hidden="true"to the active-item<Check>icon. The active state is already conveyed byaria-current="true"on the parent button, so the icon carried no independent information for screen readers. One line, matches the issue exactly, no visual change.#23 - verification only, per the issue's own scope ("do not change token values in this issue"). Independently measured every WCAG contrast claim in
src/index.css's light and dark token blocks using the standard WCAG relative-luminance formula (implemented directly, no dependency - validated against the black/white=21:1 and#767676-on-white=4.54:1 reference points before trusting it on the real tokens). Full table, codex-cross-checked (independent from-scratch reimplementation, not given my code):.kiro/cloudcertprep/A11Y-BATCH-2026-08-05.md.Result: every documented claim holds, no token fails AA (4.5:1) in its documented usage. No token value changed - this PR is code (
#95) + a verification doc (#23), nothing else.Testing
npm run check: 0 errors, 0 warnings, 300/300 tests pass.#95isaria-hiddenonly,#23changed no CSS).Checklist
npm run lintandnpm run testpass (vianpm run check)#23is verification-only per its own scope)