Skip to content

200: Remove the unused useLocale project property #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielJette wants to merge 1 commit into
base: main
Choose a base branch
from
Open

200: Remove the unused useLocale project property #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
- Fix `RootViewWithoutFocusException` being intermittently thrown by `Espresso.closeSoftKeyboard()`
- **Breaking:** `dev.testify.internal.helpers.closeSoftKeyboard()` now requires an `Activity` parameter
- Fix `ClassCastException` when passing `-PshardCount` and `-PshardIndex` to `screenshotTest` or `screenshotRecord`
- **Removed** the `useLocale` Gradle project property. It was declared but never read, and was typed
`Boolean`, so `-PuseLocale=en_CA` evaluated to `false` and could never have worked. Set the locale
per test with `TestifyConfiguration.locale` instead

## 6.0.0

Expand Down
3 changes: 0 additions & 3 deletions Plugins/Gradle/src/main/kotlin/dev/testify/internal/GradleProjectExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ val Project.android: CommonExtension<*, *, *, *, *, *>
val Project.isVerbose: Boolean
get() = (this.properties["verbose"] as? String)?.toBoolean() ?: false

val Project.useLocale: Boolean
get() = (this.properties["useLocale"] as? String)?.toBoolean() ?: false

val Project.user: Int?
get() = (this.properties["user"] as? String)?.toInt()

Expand Down
1 change: 0 additions & 1 deletion docs/docs/settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ Pass these to any Testify Gradle task with `-P`.
| `verbose` | Set to `true` to print the `adb` commands Testify runs. |
| `reportFileName` | The file name to use when copying the test report from the device. |
| `reportPath` | The local directory to copy the test report to. |
| `useLocale` | Accepted, but the library doesn't currently use it ([#200](https://github.com/ndtp/android-testify/issues/200)). |

`-PshardCount` and `-PshardIndex` fail with a `ClassCastException` in Testify 6.0.0 and earlier. With those versions, pass `numShards` and `shardIndex` as [instrumentation arguments](recipes/24-continuous-integration.md#splitting-tests-into-shards) instead.

Expand Down